stable/current bug reports

bassmadrigal · 04-02-2022, 01:55 AM

Quote:

Originally Posted by PartiZan

Very poor excuse for wrong behavior. I would say it's even funny, like saying that this is not a bug, this is feature.

Wrong behavior to you, but not by the designer of the program.

It was specifically written this way, without any possibility that it could be a bug or unintended. The developer purposefully removes everything except for the package name before looking in the PACKAGES.TXT.

Just because it doesn't work the way you expect it to work doesn't mean it isn't working as intended.

PartiZan · 04-02-2022, 10:59 AM

Quote:

Originally Posted by bassmadrigal

Wrong behavior to you, but not by the designer of the program.

It was specifically written this way, without any possibility that it could be a bug or unintended. The developer purposefully removes everything except for the package name before looking in the PACKAGES.TXT.

Just because it doesn't work the way you expect it to work doesn't mean it isn't working as intended.

Cool. I should employ this "wisdom" at work. If somebody tells me there is a bug in the code, I say: "This is by design. Wrong behavior to you, but not by the designer of the program"

ponce · 04-02-2022, 11:28 AM

Quote:

Originally Posted by PartiZan

Cool. I should employ this "wisdom" at work. If somebody tells me there is a bug in the code, I say: "This is by design. Wrong behavior to you, but not by the designer of the program"

IMHO you could apply whatever work logic you like also to opensource projects but you have to actually hire the coders first.

bassmadrigal · 04-02-2022, 01:35 PM

Quote:

Originally Posted by PartiZan

Cool. I should employ this "wisdom" at work. If somebody tells me there is a bug in the code, I say: "This is by design. Wrong behavior to you, but not by the designer of the program"

If you are the developer, the boss of the developer, or a paying customer, you can have more control over how your project functions. If you are simply an enduser who doesn't have the ability to control the development, then you are at the mercy of whether the developer thinks it's a bug or not.

Based on how this is coded, I don't believe the developer would consider this a bug. It seems very, very intentional.

Just because you don't like it doesn't mean it is a bug.

Pithium · 04-02-2022, 06:46 PM

Quote:

Originally Posted by PartiZan

Still not good. Another, but similar weird thing.

Attachment 38671

What's the problem with your slackpkg output? I didn't bother reading all the way back through the thread to find the start of this particular shitstorm.

Also.. be careful calling this a bug. You are implying that something is broken.. which is not the case here.

Slackpkg isn't giving you an error or reporting incorrect information so there is no bug here. This is at most a design flaw and should be discussed as such. If you try to suggest that this feature is broken then a bunch of people are going to get all defensive and cranky. Nobody gets a trophy for pointing out a minor quirk in the way information is displayed.

Last time I ran into an issue like this at work I literally looked at our client and asked them "what is the intended result as described in your product definition? What is it supposed to do?".

Pithium · 04-02-2022, 06:53 PM

And FWIW, I've been poking at the way slackpkg info <pkg> displays info on my screen and there is definitely room for improvement. It's not broken, but when viewing info for a package that exists in multiple repos (I'm using slackpkg+) things get pretty messy. There's definitely room for discussion on improving that output because right now it hurts my brain..

Code:

root@vapyr:~# slackpkg info mesa-compat32


NOTICE: pkglist is older than 24h; you are encouraged to re-run 'slackpkg update'

PACKAGE NAME:  mesa-compat32-21.3.5-x86_64-2compat32.txz
PACKAGE LOCATION:  ./x-compat32
PACKAGE SIZE (compressed):  20005 K
PACKAGE SIZE (uncompressed):  200780 K
PACKAGE DESCRIPTION:
mesa-compat32: mesa-compat32 (a 3-D graphics library)
mesa-compat32:
mesa-compat32: Mesa is a 3-D graphics library with an API very similar to that of
mesa-compat32: another well-known 3-D graphics library. The Mesa libraries are used
mesa-compat32: by X to provide both software and hardware accelerated graphics.
mesa-compat32:
mesa-compat32: Mesa was written by Brian Paul.
mesa-compat32:
mesa-compat32: Homepage: https://www.mesa3d.org
mesa-compat32:
mesa-compat32: This package contains 32-bit compatibility binaries.

PACKAGE NAME:  mesa-compat32-21.3.5-x86_64-2compat32.txz
PACKAGE LOCATION:  ./slackware64-compat32/x-compat32
PACKAGE SIZE (compressed):  41988 K
PACKAGE SIZE (uncompressed):  200780 K
PACKAGE DESCRIPTION:
mesa-compat32: mesa-compat32 (a 3-D graphics library)
mesa-compat32:
mesa-compat32: Mesa is a 3-D graphics library with an API very similar to that of
mesa-compat32: another well-known 3-D graphics library. The Mesa libraries are used
mesa-compat32: by X to provide both software and hardware accelerated graphics.
mesa-compat32:
mesa-compat32: Mesa was written by Brian Paul.
mesa-compat32:
mesa-compat32: Homepage: https://www.mesa3d.org
mesa-compat32:
mesa-compat32: This package contains 32-bit compatibility binaries.


Package:    mesa-compat32-21.3.5-x86_64-2compat32
Repository: compat32
Path:       ./x-compat32/mesa-compat32-21.3.5-x86_64-2compat32.txz
Url:        http://192.168.0.13/mirror/slackware/multilib/15.0/x-compat32/mesa-compat32-21.3.5-x86_64-2compat32.txz

Package:    mesa-compat32-21.3.5-x86_64-2compat32
Repository: multilib
Path:       ./slackware64-compat32/x-compat32/mesa-compat32-21.3.5-x86_64-2compat32.txz
Url:        https://taper.alienbase.nl/people/alien/multilib/15.0/slackware64-compat32/x-compat32/mesa-compat32-21.3.5-x86_64-2compat32.txz

My brain has better things to do than parse large blocks of machine readable text. I have a computer to handle those mundane tasks.

bassmadrigal · 04-02-2022, 08:32 PM

Quote:

Originally Posted by Pithium

What's the problem with your slackpkg output?

They put in a full package, including version, arch, and build number, and slackpkg stripped everything to only search PACKAGES.TXT for the package name only.

As I tried pointing out, the way this is coded leaves no chance that this wasn't intentional.

Pithium · 04-02-2022, 09:01 PM

Quote:

Originally Posted by bassmadrigal

They put in a full package, including version, arch, and build number, and slackpkg stripped everything to only search PACKAGES.TXT for the package name only.

As I tried pointing out, the way this is coded leaves no chance that this wasn't intentional.

Relax with the declarations of intent. You aren't a slackpkg dev and your name isn't credited at the top of the script

All I saw were a bunch of claims about a "bug" but no real description of what that bug was. It's clearly working as designed whether that was intentional or not. PartiZan needs to be careful throwing around words like "bug" or "broken" because some people (read: you) get all bent out of shape over a stupid semantics problem.

Either way, slackpkg is a stupidly simple script. If I cared at all about the dump of text from the info option I could have easily fixed it in the amount of time everyone here spent debating it.

PartiZan · 04-02-2022, 11:31 PM

Quote:

Originally Posted by bassmadrigal

They put in a full package, including version, arch, and build number, and slackpkg stripped everything to only search PACKAGES.TXT for the package name only.

As I tried pointing out, the way this is coded leaves no chance that this wasn't intentional.

This was not intentional for sure; It was written and forgotten. It's not by design, but by negligence.

Pithium · 04-03-2022, 12:13 AM

Quote:

Originally Posted by PartiZan

This was not intentional for sure; It was written and forgotten. It's not by design, but by negligence.

A softer tone in regards to unpolished features is a good idea here. There's been a lot of work done on the mission-critical features of slackpkg in the past few years so it's not surprising that one of the lesser used functions just dumps an ugly wad of text to the screen without any extra formatting.

You pointed out a good area for improvement so don't ruin it by suggesting that the developers who donated their free time to the project should have worked harder.

Pithium · 04-03-2022, 12:20 AM

Since I know 15.0 attracted a bunch of new users, this whole situation presents a learning opportunity regarding how slackware packages are updated.

Line 513 in /usr/sbin/slackpkg is the source of your frustration.

Code:

	info)
		PATTERN=$(echo $ARG | sed -e 's/\+/\\\+/g' -e 's/\./\\\./g')
		NAME=$(cutpkg $PATTERN)
		awk -F: "/PACKAGE NAME:.* ${NAME}-[^-]+-(${ARCH}|fw|noarch)-[^-]+/,/^$/ {
                                found=1
				 if (\$1 ~ /"$NAME"/) {
				 print \$PATTERN 
				} else {
				print \$0
				} 
                        }
                        END {
				if ( found != 1 ) {
			print \"No packages found! Try:\n\n\tslackpkg search $PATTERN\n\nand choose one (and ONLY one package).\n\"
				}
			}" ${WORKDIR}/PACKAGES.TXT 2>/dev/null

Instead of being toxic and accusing volunteer developers of being negligent, maybe clean it up yourself so we can all celebrate?

PartiZan · 04-03-2022, 12:51 AM

Quote:

Originally Posted by Pithium

Relax with the declarations of intent. You aren't a slackpkg dev and your name isn't credited at the top of the script

All I saw were a bunch of claims about a "bug" but no real description of what that bug was. It's clearly working as designed whether that was intentional or not. PartiZan needs to be careful throwing around words like "bug" or "broken" because some people (read: you) get all bent out of shape over a stupid semantics problem.

Either way, slackpkg is a stupidly simple script. If I cared at all about the dump of text from the info option I could have easily fixed it in the amount of time everyone here spent debating it.

The whole Slackware is simple and stupid thing (and some targeted groups of people love it for that). On the other hand, "slackpkg info" behaves in a very shitty way. The excuse about stupidly simple script doesn't work. It is negligence, not simplicity.

PartiZan · 04-03-2022, 01:03 AM

Quote:

Originally Posted by Pithium

Since I know 15.0 attracted a bunch of new users, this whole situation presents a learning opportunity regarding how slackware packages are updated.

Line 513 in /usr/sbin/slackpkg is the source of your frustration.

Code:

	info)
		PATTERN=$(echo $ARG | sed -e 's/\+/\\\+/g' -e 's/\./\\\./g')
		NAME=$(cutpkg $PATTERN)
		awk -F: "/PACKAGE NAME:.* ${NAME}-[^-]+-(${ARCH}|fw|noarch)-[^-]+/,/^$/ {
                                found=1
				 if (\$1 ~ /"$NAME"/) {
				 print \$PATTERN 
				} else {
				print \$0
				} 
                        }
                        END {
				if ( found != 1 ) {
			print \"No packages found! Try:\n\n\tslackpkg search $PATTERN\n\nand choose one (and ONLY one package).\n\"
				}
			}" ${WORKDIR}/PACKAGES.TXT 2>/dev/null

Instead of being toxic and accusing volunteer developers of being negligent, maybe clean it up yourself so we can all celebrate?

I can do that locally, not a big deal.

Trying to suggest things to improve is something toxic now...

ponce · 04-03-2022, 01:07 AM

Quote:

Originally Posted by PartiZan

Still not good. Another, but similar weird thing.

Attachment 38671

Quote:

Originally Posted by PartiZan

Very poor excuse for wrong behavior. I would say it's even funny, like saying that this is not a bug, this is feature.

Quote:

Originally Posted by PartiZan

Cool. I should employ this "wisdom" at work. If somebody tells me there is a bug in the code, I say: "This is by design. Wrong behavior to you, but not by the designer of the program"

Quote:

Originally Posted by PartiZan

This was not intentional for sure; It was written and forgotten. It's not by design, but by negligence.

Quote:

Originally Posted by PartiZan

The whole Slackware is simple and stupid thing (and some targeted groups of people love it for that). On the other hand, "slackpkg info" behaves in a very shitty way. The excuse about stupidly simple script doesn't work. It is negligence, not simplicity.

sorry PartiZan, but what's the point of complaining about it here on this forum?
if you think this is a bug open an issue on slackpkg's issues tracker

Quote:

Originally Posted by PartiZan

I can do that locally, not a big deal.

and if you have a patch for it, better!

Quote:

Originally Posted by PartiZan

Trying to suggest things to improve is something toxic now... Well, what I can say is go to my black list for your stupidity.

...but please avoid personal attacks.

allend · 04-03-2022, 01:11 AM

The slackpkg "info" option works by parsing the ${WORKDIR}/PACKAGES.TXT file. The file is created by the slackpkg "update" option and is ordered by the PRIORITY setting in /etc/slackpkg/slackpkg.conf.
If the desired behaviour is to stop the output from "slackpkg info" after the highest priority match is found, then

Code:

diff -u3  /usr/sbin/slackpkg.orig /usr/sbin/slackpkg
--- /usr/sbin/slackpkg.orig	2022-04-03 14:58:05.614835271 +1000
+++ /usr/sbin/slackpkg	2022-04-03 15:39:45.020798168 +1000
@@ -521,6 +521,7 @@
 				print \$0
 				} 
                         }
+                        { if ( found == 1 && (! \$0) ) {exit} }
                         END {
 				if ( found != 1 ) {
 			print \"No packages found! Try:\n\n\tslackpkg search $PATTERN\n\nand choose one (and ONLY one package).\n\"

Personally, I have no peeve with the existing behaviour. As shown above, it can be altered, but I would not like it to be the default due to the interaction with the PRIORITY setting.