slackpkg upgrade-all error: comm: input is not in sorted order

BenCollver · 12-23-2022, 10:04 AM

This morning i ran "slackpkg update" and then "slackpkg upgrade-all" and it gave me the error message below [1]. My /etc/slackpkg/mirrors file is configured to use https://mirrors.osuosl.org/pub/slack...ckware64-15.0/

Is this a known issue?

[1]

Code:

# slackpkg upgrade-all

Checking local integrity... DONE
Looking for packages to upgrade. Please wait... comm: file 2 is not in sorted order
comm: input is not in sorted order
DONE

No packages match the pattern for upgrade. Try:

        /usr/sbin/slackpkg install|reinstall

keefaz · 12-23-2022, 07:16 PM

It seems like slackpkg had a problem creating packages list file
As a test, maybe try (as root)

Code:

cd /var/lib
mv slackpkg slackpkg.old
mkdir slackpkg
slackpkg update
slackpkg upgrade-all

edit, maybe verify before if it's not a locale collation issue (no likely but just in case)

Code:

LC_COLLATE=C slackpkg upgrade-all

BenCollver · 12-23-2022, 10:16 PM

Neither suggestion resolved my error message. This is on Slackware64 15.0.

The following change happens to silence the error:

Code:

--- /usr/libexec/slackpkg/core-functions.sh.orig        2022-01-16 00:52:09.000000000 -0800
+++ /usr/libexec/slackpkg/core-functions.sh     2022-12-23 20:08:34.352935796 -0800
@@ -621,7 +621,7 @@
        cut -f2 -d\  ${TMPDIR}/tmplist | sort > ${TMPDIR}/lpkg
        cat ${TMPDIR}/pkglist ${TMPDIR}/tmplist | \
                cut -f2-6 -d\ |sort | uniq -u | \
-               cut -f1 -d\  | uniq > ${TMPDIR}/dpkg
+               cut -f1 -d\  | uniq | sort > ${TMPDIR}/dpkg
 }
 
 # Create a blacklist of single package names from regexps in original blacklist

Before this change, ${TMPDIR}/dpkg has libxml++ after libxml2.

After this change, ${TMPDIR}/dpkg has libxml++ before libxml2.

I suppose this error has been thrown ever since i installed SBo libxml++ and i just didn't notice it until now.

chrisretusn · 12-24-2022, 02:49 AM

Quote:

Originally Posted by BenCollver

Neither suggestion resolved my error message. This is on Slackware64 15.0.

The following change happens to silence the error:

Code:

--- /usr/libexec/slackpkg/core-functions.sh.orig        2022-01-16 00:52:09.000000000 -0800
+++ /usr/libexec/slackpkg/core-functions.sh     2022-12-23 20:08:34.352935796 -0800
@@ -621,7 +621,7 @@
        cut -f2 -d\  ${TMPDIR}/tmplist | sort > ${TMPDIR}/lpkg
        cat ${TMPDIR}/pkglist ${TMPDIR}/tmplist | \
                cut -f2-6 -d\ |sort | uniq -u | \
-               cut -f1 -d\  | uniq > ${TMPDIR}/dpkg
+               cut -f1 -d\  | uniq | sort > ${TMPDIR}/dpkg
 }
 
 # Create a blacklist of single package names from regexps in original blacklist

Before this change, ${TMPDIR}/dpkg has libxml++ after libxml2.

After this change, ${TMPDIR}/dpkg has libxml++ before libxml2.

I suppose this error has been thrown ever since i installed SBo libxml++ and i just didn't notice it until now.

I have had libxml++ installed for a number of years, no such is issue here. I just tested this by changing the build number of my package from libxml++-2.42.2-x86_64-1cgs.txz to libxml++-2.42.2-x86_64-2cgs.txz, ran update & upgrade-all, works fine, had additional updates in the upgrade-all too. (Fri Dec 23 20:27:02 UTC 2022; Fri Dec 23 02:37:47 UTC 2022; Thu Dec 22 03:40:55 UTC 2022)

This is in the complete unmodified function from core-functions.sh in my installed version of slackpkg (slackpkg-15.0.10-noarch-2.txz) which is for -current only, slackpkg-15.0.10-noarch-1.txz has the exact same code.

Code:

function listpkgname() {
	cut -f2 -d\  ${TMPDIR}/pkglist | sort > ${TMPDIR}/spkg	
	cut -f2 -d\  ${TMPDIR}/tmplist | sort > ${TMPDIR}/lpkg
	cat ${TMPDIR}/pkglist ${TMPDIR}/tmplist | \
		cut -f2-6 -d\ |sort | uniq -u | \
		cut -f1 -d\  | uniq > ${TMPDIR}/dpkg
}

Just to clarify what I am saying, it it works without modification to core-functions.sh, it must be something else.

henca · 12-24-2022, 03:20 AM

Quote:

Originally Posted by BenCollver

Code:

-               cut -f1 -d\  | uniq > ${TMPDIR}/dpkg
+               cut -f1 -d\  | uniq | sort > ${TMPDIR}/dpkg

The odd thing with that solution, sorting the output from uniq, is that uniq itself assumes that its input is sorted. From the man-page of uniq:

Quote:

Note: 'uniq' does not detect repeated lines unless they are adjacent. You may want to sort the input first, or use 'sort -u' without 'uniq'.

regards Henrik

BenCollver · 12-24-2022, 10:42 AM

I reverted to the original code and reproduced the error.

I unset LC_ALL and that resolved the error.

I originally had LC_ALL=en_US.UTF-8

Perhaps it was a locale issue after all.

keefaz · 12-24-2022, 11:00 AM

Maybe you made slackpkg delete, modify the culprit file, I could not find a locale setting which would make sort put libxml2 before libxml++

chrisretusn · 12-24-2022, 11:50 AM

Quote:

Originally Posted by BenCollver

I reverted to the original code and reproduced the error.

I unset LC_ALL and that resolved the error.

I originally had LC_ALL=en_US.UTF-8

Perhaps it was a locale issue after all.

This could explain why I was not having this issue. I've never set LC_ALL, just about everything else is set to en_US.UTF-8.

It is late, time for bed. I will set LC_ALL to en_US.UTF-8 and see what happens tomorrow.

BenCollver · 04-09-2024, 08:14 AM

As it turns out, en_US.UTF-8 is not a valid locale. On Slackware 15.0 it is en_US.utf8 as shown in locale -a

Petri Kaukasoina · 04-09-2024, 08:43 AM

Quote:

Originally Posted by BenCollver

As it turns out, en_US.UTF-8 is not a valid locale. On Slackware 15.0 it is en_US.utf8 as shown in locale -a

en_US.UTF-8 is ok. Then the directories under /usr/lib64/locale are searched in this order:

en_US.UTF-8
en_US.utf8
en_US
en.UTF-8
en.utf8
en

The first one found is en_US.utf8.