[SOLVED] if [[ -n "$1" ]]; then FAIL FAIL FAIL

rbees · 03-24-2015, 05:21 PM

Ladies & Gents

Thanks for your patients with my old slow learning brain.

I have not been able to figure out why this fails.

if [[ -n "$1" ]]; then I have also tried
if [[ -z "$1" ]]; then which only fails the other way.

The variable $1 is the first passed into the function this is part of and contains something like 20:34 which is a time that is used in a different function to schedule an "at" job.

The line above needs to "add" or "omit" some text that is dumped into a file for latter processing based on if this time data exists or not. Because it fails the whole function fails to generate the proper files. :Grrrrr:

In a different part of the larger project there in an almost identical line that works just fine.

if [[ -n "$YOMTOVE" ]]; then

The only difference that I know of is that this one has words in the variable like "Pesach" and the other one has the time as I mentioned before.

Any idea's

thanks

Miati · 03-24-2015, 05:30 PM

put this at the top of the script

Code:

set -xv

Then post the output relevant to if [[ -n "$1" ]];
It should preface with a +

It'll show what is actually being compared so there's less guessing on what is being compared.

suicidaleggroll · 03-24-2015, 05:45 PM

Works fine for me...

Code:

$ var="20:34"
$ if [[ -n "$var" ]]; then echo 1; fi
1
$ if [[ -z "$var" ]]; then echo 1; fi
$ var=""
$ if [[ -n "$var" ]]; then echo 1; fi
$ if [[ -z "$var" ]]; then echo 1; fi
1

rbees · 03-24-2015, 06:29 PM

I found the issue. The variable is not being unset as I thought it would in the calling loop. It occurred to me while I was eating dinner. Checked it out an sure enough that's it. Now all I have to do is figure out the best way to do it.

Can I pass it in like the red text making it unset?

The offending code:

Code:

# Set up the Omer count
# needs LONG LAT TZ CITY STATE ZIP passed in
function Count_Omer {
  CURENTDAY=$( hdate -q --not-sunset-aware $DAY $MONTH $YEAR|awk '{print $5;}' )
  CURENTMONTH=$( hdate -q --not-sunset-aware $DAY $MONTH $YEAR|awk '{print $6;}' )
  echo "$CURENTDAY $CURENTMONTH"
  if echo $CURENTMONTH | grep -e Nisan -e Iyyar -e Sivan ;then
    if (( "$CURENTMONTH" == "Nisan" && "$CURENTDAY" > 15 ));then
      OMER=$(hdate -oq $DAY $MONTH $YEAR | awk 'NR==3'|awk '{print $4}')
      MORNOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunrise/{print $2}')"
      Omer_Blessing "$EVEOMER=""" "$OMER" "${OMER}_Omer_Morning"
      at "$MORNOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Morning
      EVEOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunset/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Evening"
      at "$EVEOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Evening
      return
    elif (( "$CURENTMONTH" == "Iyyar" ));then
      OMER=$(hdate -oq $DAY $MONTH $YEAR | awk 'NR==3'|awk '{print $4}')
      MORNOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunrise/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Morning"
      at "$MORNOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Morning
      EVEOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunset/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Evening"
      at "$EVEOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Evening
      return
    elif (( "$CURENTMONTH" == "Sivan" && "$CURENTDAY" < 6 ));then
      OMER=$(hdate -oq $DAY $MONTH $YEAR | awk 'NR==3'|awk '{print $4}')
      MORNOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunrise/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Morning"
      at "$MORNOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Morning
      EVEOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunset/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Evening"
      at "$EVEOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Evening
      return
    else 
      return
    fi
  else
    return
  fi
}

Thanks

rbees · 03-24-2015, 07:26 PM

no joy on that had to use

unset var

Thanks again

rbees · 03-25-2015, 11:54 AM

Well It seams that I lied about having the problem solved.

After I added this piece into the larger project and tried to run it, it still fails.

So here is the code that is failing

Code:

unction Count_Omer {
  CURENTDAY=$( hdate -q --not-sunset-aware $DAY $MONTH $YEAR|awk '{print $5;}' )
  CURENTMONTH=$( hdate -q --not-sunset-aware $DAY $MONTH $YEAR|awk '{print $6;}' )
  echo "$CURENTDAY $CURENTMONTH"
  if echo $CURENTMONTH | grep -e Nisan -e Iyyar -e Sivan ;then
    if (( "$CURENTMONTH" == "Nisan" && "$CURENTDAY" > 15 ));then
      OMER=$(hdate -oq $DAY $MONTH $YEAR | awk 'NR==3'|awk '{print $4}')
      MORNOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunrise/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Morning"
      at "$MORNOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Morning
      EVEOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/first_stars/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Evening"
      at "$EVEOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Evening
      unset EVEOMER
      unset MORNOMER
      return
    elif (( "$CURENTMONTH" == "Iyyar" ));then # Should fail here
      OMER=$(hdate -oq $DAY $MONTH $YEAR | awk 'NR==3'|awk '{print $4}')
      MORNOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunrise/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Morning"
      at "$MORNOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Morning
      EVEOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/first_stars/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Evening"
      at "$EVEOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Evening
      unset EVEOMER
      unset MORNOMER
      return
    elif (( "$CURENTMONTH" == "Sivan" && "$CURENTDAY" < 6 ));then
      OMER=$(hdate -oq $DAY $MONTH $YEAR | awk 'NR==3'|awk '{print $4}')
      MORNOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/sunrise/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Morning"
      at "$MORNOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Morning
      EVEOMER="$(hdate -t -L$LONG -l$LAT -z$TZ $DAY $MONTH $YEAR | awk '/first_stars/{print $2}')"
      Omer_Blessing "$EVEOMER" "$OMER" "${OMER}_Omer_Evening"
      at "$EVEOMER" "$MONTH/$DAY/$YEAR" -f "$TMPDIR"/${OMER}_Omer_Evening
      unset EVEOMER
      unset MORNOMER
      return
    else
      echo "No Count today"
      return
    fi
  else
    echo "Not Spring"
    return
  fi
}

And the debug with some comments I added:

Code:

+ Count_Omer
++ hdate -q --not-sunset-aware 25 03 2015
++ awk '{print $5;}'
+ CURENTDAY='
5'
++ hdate -q --not-sunset-aware 25 03 2015
++ awk '{print $6;}'
+ CURENTMONTH='
Nisan'
+ echo '
5 
Nisan'

5         # Hebrew day
Nisan     # Hebrew Month
+ echo Nisan
+ grep -e Nisan -e Iyyar -e Sivan
Nisan
+ ((  
Nisan == Nisan &&   # pass
5 > 15  ))          # Hebrew day less than 15 = fail
+ ((  
Nisan == Iyyar  ))  # Hebrew months not the same, should fail but dosen't
++ hdate -oq 25 03 2015
++ awk NR==3
++ awk '{print $4}'
+ OMER=
++ hdate -t -L-85.9588 -l41.7381 -z-4 25 03 2015
++ awk '/sunrise/{print $2}'
+ MORNOMER=07:40
+ Omer_Blessing '' '' _Omer_Morning
+ week=(7 14 21 28 35 42 49)
+ omer=(1 2 3 4 5 6)
+ [[ -z '' ]]
+ echo 'We don'\''t say the blessing durring the daylight hours'
We don't say the blessing durring the daylight hours
+ Element_In '' 1 2 3 4 5 6
+ local e
+ for e in '"${@:2}"'
+ [[ 1 == '' ]]

ntubski · 03-25-2015, 12:03 PM

(()) is for numeric comparisons only. Use

Code:

[[ "$CURENTMONTH" == "Nisan" ]] && ((CURENTDAY > 15))

rbees · 03-25-2015, 02:39 PM

Thanks ntubski

That did the trick. I think I only have one left. Think being the operative word. Also the variable issue I was having in a different thread, I did not need not need to export them.

Thanks again for all your kindness