LinuxQuestions.org
Welcome to the most active Linux Forum on the web.
Home Forums Tutorials Articles Register
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 08-03-2022, 12:05 PM   #1
nobodino
Senior Member
 
Registered: Jul 2010
Location: Near Bordeaux in France
Distribution: slackware, slackware from scratch, LFS, slackware [arm], linux Mint...
Posts: 1,564

Rep: Reputation: 892Reputation: 892Reputation: 892Reputation: 892Reputation: 892Reputation: 892Reputation: 892
xf86-video-vmware doesn't built in -current


xf86-video-vmware doesn't built anymore in -current:

Code:
vmwgfx_tex_video.c:240:20: error: the comparison will always evaluate as ‘true’ for the address of ‘yuv’ will never be NULL [-Werror=address]
  240 |                if (priv->yuv[i]) {
      |                    ^~~~
vmwgfx_tex_video.c:125:24: note: ‘yuv’ declared here
  125 |     struct xa_surface *yuv[2][3];
      |                        ^~~
cc1: some warnings being treated as errors
make[2]: *** [Makefile:497: libvmwgfx_la-vmwgfx_tex_video.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/tmp/x11-build/xf86-video-vmware-13.3.0/vmwgfx'
make[1]: *** [Makefile:449: all-recursive] Error 1
make[1]: Leaving directory '/tmp/x11-build/xf86-video-vmware-13.3.0'
make: *** [Makefile:381: all] Error 2
This page gives a solution : https://gitlab.freedesktop.org/xorg/...are/-/issues/9

Here is a small patch which solves the problem:

Code:
diff -aurN xf86-video-vmware-13.3.0/vmwgfx/vmwgfx_tex_video.c xf86-video-vmware-13.3.0-mod/vmwgfx/vmwgfx_tex_video.c
--- xf86-video-vmware-13.3.0/vmwgfx/vmwgfx_tex_video.c	2018-05-17 09:42:24.000000000 +0200
+++ xf86-video-vmware-13.3.0-mod/vmwgfx/vmwgfx_tex_video.c	2022-08-03 18:58:09.951798799 +0200
@@ -237,7 +237,7 @@
 
        for (i=0; i<3; ++i) {
 	   for (j=0; j<2; ++j) {
-	       if (priv->yuv[i]) {
+	       if (priv->yuv[j][i]) {
 		   xa_surface_destroy(priv->yuv[j][i]);
 		   priv->yuv[j][i] = NULL;
 	       }
 
Old 08-09-2022, 01:22 AM   #2
nobodino
Senior Member
 
Registered: Jul 2010
Location: Near Bordeaux in France
Distribution: slackware, slackware from scratch, LFS, slackware [arm], linux Mint...
Posts: 1,564

Original Poster
Rep: Reputation: 892Reputation: 892Reputation: 892Reputation: 892Reputation: 892Reputation: 892Reputation: 892
solved in -current by upgraded version.
Thanks to PV.
 
  


Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] found patches to build xf86-server-s3virge and xf86-server-tseng nobodino Slackware 1 07-14-2018 07:09 AM
slackware-current xorg-server-1.20.0 with xf86-video-nouveau segfaults Rod3775 Slackware 17 05-22-2018 09:22 PM
[SOLVED] armsoc_dri.so missing from xf86-video-armsoc-1.4.0-arm-2 in -current Linux.tar.gz Slackware - ARM 1 12-22-2015 04:13 PM
xf86-video-ati-6.12.5 on --current == NICE! Old_Fogie Slackware 28 03-17-2010 06:52 AM
xf86-input-keyboard and xf86-input-mouse masked CollieJim Gentoo 4 11-09-2009 09:57 PM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 08:21 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration