Small typo

jostber · 07-08-2013, 11:25 AM

I found a small typo in a rc file when setting up postfix the other day. Is there somewhere to report this?

Didier Spaier · 07-08-2013, 12:59 PM

Here.

jostber · 07-08-2013, 01:08 PM

From /etc/rc.d/rc.saslauthd:

Code:

#!/bin/sh# rc.saslauthd:  start/stop/restart saslauthd
#
# saslauthd is a daemon process that handles plaintext authentication
# requests on behalf of the SASL library.  The CMU Cyrus SASL library
# is a general purpose authentication library for sever and client
# applications.  It is mostly used to authenticate to mail servers.
#
# saslauthd should be started from the system boot scripts when going
# to multi-user mode. When running against a protected authentication

Should be "authentication library for server and client".

perbh · 07-08-2013, 01:42 PM

oh man ... who cares about comments?

Woodsman · 07-08-2013, 02:30 PM

Quote:

oh man ... who cares about comments?

The OP is trying to help. Your comment does not help.

jostber, you can post such comments here at LQ. Pat follows the forum. You also can send him an email with such a change.

perbh · 07-08-2013, 03:00 PM

I stand corrected - sorry.

zhjim · 07-08-2013, 03:09 PM

jostber does.

And thats good. Also this beeing just a typo no one can misread there are ones than if interpreted in a not so wise background could lead to false assumption and wasted hours of lifetime. If you got spare I take.

volkerdi · 07-08-2013, 03:12 PM

Fixed in the source tree, so it'll be picked up by the next update to cyrus-sasl (whenever that happens).

onebuck · 07-08-2013, 04:58 PM

Hi,

Quote:

Originally Posted by perbh

oh man ... who cares about comments?

People that care about following what the author intended. Sure a typo is minor but one should be aware and voice when an error exists or found.

perbh · 07-09-2013, 09:30 PM

Seeing everybody thinks mis-spellings might be a real-bad-thing, I guess the following should also be considered for updates:

Quote:

rc.autofs:33:# load customized configuation settings
rc.cups:27:# NetBSD 1.5+ rcorder script lines. The format of the following two
rc.inet1.conf:80:#IFNAME[4]="wlan0" # Use a different interface name nstead of
rc.inet1.conf:85:#DHCP_KEEPRESOLV[4]="yes" # If you dont want /etc/resolv.conf overwritten
rc.wireless:50:# need this additional time to initalize.

I don't really dare to think what a similar exercise into the kernel source would bring - but for anyone sufficiently interested - the above was done by:

Code:

#!/bin/sh
cd /etc/rc.d
for f in *; do
   test -d $f && continue	# skip directories
   test ${f:0:11} = rc.modules- && continue	# only use default
   grep -n '^#' $f | grep -v '#$' | while read t; do
      echo "$f:$t"
   done
done

The result was piped through a spell-checker ('aspell' in this case) - and after a few k-keypushes of 'i' (ignore) - the output was as above.
getting somewhat tired-eye at the end - I might well have missed some ...

I would appreciate if the above could be given the same serious attitude as given to the OP ...

ps.
I do apologize if I have stepped on anybody's toes - but sometimes there is a li'l ole devil sittin' on one's shoulder ...

mlslk31 · 07-09-2013, 09:46 PM

Quote:

rc.cups:27:# NetBSD 1.5+ rcorder script lines. The format of the following two

Not sure about this one. In FreeBSD, "rcorder" is a program that provides the dependency order for the rc files. I've used it like `cd /etc/rc.d; rcorder ./*`, and it lists the order in which the scripts can be run. It's a nice aid when adding new rc files.

volkerdi · 07-09-2013, 09:47 PM

Quote:

Originally Posted by perbh

Seeing everybody thinks mis-spellings might be a real-bad-thing, I guess the following should also be considered for updates:

...

I would appreciate if the above could be given the same serious attitude as given to the OP ...

I wouldn't say they fall into the same category as functional bugs, but certainly they should be fixed (or at least set up for an eventual fix... I'll rarely rebuild just to fix a typo).

BTW, rc.autofs and rc.cups came from upstream that way, so if it's really bothering you I'd suggest reporting it to them. Fixing typos is one thing, but patching them is another.

perbh · 07-09-2013, 10:26 PM

*chuckles* it's certainly not bothering _me_ - as far as I'm concerned - a comment is a comment - and unless the comment kinda 'spells out' what you've got to do (eg. commented scripts), I couldn't care less.
As for 'rcorder' I sincerely apologize - I believed that to be 'reorder' (possibly 'recorder') - my bad!

As I said - there was this li'l mischievous fella sittin' on my shoulder ...