How to find proper --enable options when building wxGTK3?

kgha · 06-28-2021, 04:45 AM

When trying to build the latest dvdstyler (3.2) I found that this required upgrades of wxGTK3 (> 3.1.5) and wxsvg (> 1.5.22). Building with ponce's buildscripts for -current went fine, but dvdstyler still refused to build, complaining over a missing wxGTK3 header file (colrdlgg.h).

The source package contains the file in question (wxWidgets-3.1.5/include/wx/generic/colrdlgg.h) but for some reason it wasn't included in the .tgz package. My dirty solution was to extract the header file from the source, putting it in its proper place in the -tgz package. Then I could build dvdstyler without issues.

I realise that my solution is not the proper one. I probably need to add a --enable line to the buildscript but I have no clue to what should be enabled - maybe --enable-colourdialog or something similar. Haven't found any hints when googling.

Any ideas?

kermitdafrog8 · 06-28-2021, 06:52 AM

--enable-coldlg use wxColourDialog

Maybe this is what you are looking for?

kgha · 06-28-2021, 10:25 AM

Thanks, that looked like a very promising suggestion. However, after adding
--enable-coldlg \
to the build script, the file was still missing when the package was built.

joghi · 06-28-2021, 01:26 PM

I'm not sure if the header for the generic dialog is still installed for linux systems for newer versions of wxWidgets. However, if you look at the code in wxVillaLib/PropDlg.cpp in lines 764 ff you see, that the generic dialog is only used if __WXMSW__ is defined. So I think you can safely delete the line #include <wx/generic/colrdlgg.h> for your Slackware build. The proper solution might be to use a patch file, e.g.

Code:

diff -Naur DVDStyler-3.2/wxVillaLib/PropDlg.cpp DVDStyler-3.2_patched/wxVillaLib/PropDlg.cpp
--- DVDStyler-3.2/wxVillaLib/PropDlg.cpp        2021-06-22 09:13:11.000000000 +0200
+++ DVDStyler-3.2_patched/wxVillaLib/PropDlg.cpp        2021-06-28 19:26:44.646851316 +0200
@@ -12,7 +12,6 @@
 #include "utils.h"
 #include <wx/fontdlg.h>
 #include <wx/colordlg.h>
-#include <wx/generic/colrdlgg.h>
 #include <wx/filedlg.h>
 #include <wx/dirdlg.h>
 #include <wx/grid.h>
@@ -29,6 +28,7 @@
 #ifdef __WXMSW__
 #include <setupapi.h>
 #include "wx/msw/private.h"
+#include <wx/generic/colrdlgg.h>
 #endif

 #include "rc/delete.png.h"

to include colrdlgg.h only, if __WXMSW__ is defined.

kgha · 06-29-2021, 04:56 AM

Thanks, much obliged! Couldn't get the patch to work (first change accepted, second rejected), but simply deleting the line

Code:

#include <wx/generic/colrdlgg.h>

did the trick, build went smooth and the program works as intended.

Causes me another headache, though. Filezilla refuses to run (or compile) on anything but a "stable" wxGTK3, i.e. version 3.0.5. Well, I can live with that for now and sort it out when the next stable wxWidget release arrives.