Building the KDE4 for Slackware 15.0 in the KTown style - a build based on the PBSLACKS patches

BrunoLafleur · 05-13-2023, 10:35 AM

Quote:

Originally Posted by LuckyCyborg

Well, in the latest getGraphicsProcessor() presented by me (at suggestion of my friend) the (TM) and (R) are already parsed by fancyString() before the cut is done. And was triple checked that a similar logic is done by the code from Plasma5.

But with some of my computers it doesn't work. So I don't strip it in my version.

BrunoLafleur · 05-13-2023, 10:46 AM

Quote:

Originally Posted by ZhaoLin1457

If @BrunoLafleur allows me, I would like to remind him of the maximum 4 thumbnails in the taskbar. It would be nice to have a maximum of 6 or 7 thumbnails.

With that about-distro, you seem to have solved it. Heartiest congratulations!

For the taskbar it is difficult to find. I have not looked to the right direction until now. If I find it I will tell you.

BrunoLafleur · 05-14-2023, 07:14 AM

For about-distro, I have made a new patch with the last version from LuckyCyborg and the translations po files for the "Graphics Processor" item.

So now I have it in french like the others items.

The patch is here :
https://github.com/BrunoLafleur/pbsl...o-gpu.patch.gz

Note than in pbslacks I have put about-distro in extragear as suggested above. So I have updated kde/modules/extragear and kde/slack-desc

BrunoLafleur · 05-14-2023, 08:49 AM

I have also added a fallback for the cpu info which was not showing in one of my machine because some /sys cpu information are not there.

In the last version of the about-distro patch :
https://github.com/BrunoLafleur/pbsl...o-gpu.patch.gz

BrunoLafleur · 05-14-2023, 08:58 AM

And a new snapshot of about-distro in KInfoCenter.

LuckyCyborg · 05-14-2023, 09:03 AM

@BrunoLafleur

While we are at this, do you know what I believe to be very nice?

To have this about-distro page as default (if exists) in KInfoCenter, like in Plasma5 .

So, I guess that this "About Distro" page to have a higher priority than "Summary" page, which is the first.

LuckyCyborg · 05-14-2023, 12:23 PM

@BrunoLafleur

I have managed to successfully build Krusader on kde4town, but I have build issues with the (associated) Krename. Maybe you can take a look.

I have used the patches from there:

https://mandriva.c3sl.ufpr.br/offici....0.9-2.src.rpm

and this patch

Code:

Author: Pino Toscano <toscano.pino@tiscali.it>
Description: Fix flags for KIO::file_delete()
 .
 Pass a proper value for flags, instead of a boolean.
 .
 This fixes the build with GCC 6.
Last-Update: 2016-06-26
Forwarded: no

--- a/src/batchrenamer.cpp
+++ b/src/batchrenamer.cpp
@@ -402,7 +402,7 @@ void BatchRenamer::undoFiles( ProgressDi
                 break;
             case eRenameMode_Link:
                 // In case of link delete created file
-                job = KIO::file_delete( dstUrl, false );
+                job = KIO::file_delete( dstUrl, KIO::HideProgressInfo );
                 break;
             case eRenameMode_Copy: // no undo possible
                 // TODO: Maybe we should delete the created files

The build failure is this:

Code:

[  2%] Building CXX object src/CMakeFiles/krename.dir/pluginloader.o
In file included from /tmp/kde_build/extragear/krename-4.0.9/src/pluginloader.cpp:40:
/tmp/kde_build/extragear/krename-4.0.9/src/fontplugin.h:28:10: fatal error: ft2build.h: No such file or directory
   28 | #include <ft2build.h>
      |          ^~~~~~~~~~~~

For Krusader, I have used this patch named krusader-gcc11.patch made by my friend :

Code:

diff -urN krusader-389b153d_20160328git.orig/krusader/Dialogs/packgui.cpp krusader-389b153d_20160328git/krusader/Dialogs/packgui.cpp
--- krusader-389b153d_20160328git.orig/krusader/Dialogs/packgui.cpp	2023-05-13 10:34:19.000000000 +0300
+++ krusader-389b153d_20160328git/krusader/Dialogs/packgui.cpp	2023-05-14 19:26:16.455499375 +0300
@@ -40,7 +40,7 @@
 #include <QtGui/QComboBox>
 #include <khistorycombobox.h>
 
-#define PS(x) lst.contains(x)>0
+#define PS(x) lst.contains(x)
 
 // clear the statics first
 QString PackGUI::filename = 0;
diff -urN krusader-389b153d_20160328git.orig/krusader/Konfigurator/kgarchives.cpp krusader-389b153d_20160328git/krusader/Konfigurator/kgarchives.cpp
--- krusader-389b153d_20160328git.orig/krusader/Konfigurator/kgarchives.cpp	2023-05-13 10:34:19.000000000 +0300
+++ krusader-389b153d_20160328git/krusader/Konfigurator/kgarchives.cpp	2023-05-14 19:30:20.902479786 +0300
@@ -163,7 +163,7 @@
 
 void KgArchives::disableNonExistingPackers()
 {
-#define PS(x) lst.contains(x)>0
+#define PS(x) lst.contains(x)
 
     // get list of available packers
     QStringList lst = KRarcHandler::supportedPackers();
diff -urN krusader-389b153d_20160328git.orig/krusader/Konfigurator/krresulttable.cpp krusader-389b153d_20160328git/krusader/Konfigurator/krresulttable.cpp
--- krusader-389b153d_20160328git.orig/krusader/Konfigurator/krresulttable.cpp	2023-05-13 10:34:19.000000000 +0300
+++ krusader-389b153d_20160328git/krusader/Konfigurator/krresulttable.cpp	2023-05-14 19:30:58.904476741 +0300
@@ -27,7 +27,7 @@
 
 using namespace std;
 
-#define PS(x) _supported.contains(x)>0
+#define PS(x) _supported.contains(x)
 
 KrResultTable::KrResultTable(QWidget* parent)
         : QWidget(parent),
diff -urN krusader-389b153d_20160328git.orig/krusader/MountMan/kmountman.cpp krusader-389b153d_20160328git/krusader/MountMan/kmountman.cpp
--- krusader-389b153d_20160328git.orig/krusader/MountMan/kmountman.cpp	2023-05-13 10:34:19.000000000 +0300
+++ krusader-389b153d_20160328git/krusader/MountMan/kmountman.cpp	2023-05-14 19:29:54.894481870 +0300
@@ -109,18 +109,18 @@
 
 bool KMountMan::invalidFilesystem(QString type)
 {
-    return (invalid_fs.contains(type) > 0);
+    return invalid_fs.contains(type);
 }
 
 // this is an ugly hack, but type can actually be a mountpoint. oh well...
 bool KMountMan::nonmountFilesystem(QString type, QString mntPoint)
 {
-    return((nonmount_fs.contains(type) > 0) || (nonmount_fs_mntpoint.contains(mntPoint) > 0));
+    return (nonmount_fs.contains(type) || nonmount_fs_mntpoint.contains(mntPoint));
 }
 
 bool KMountMan::networkFilesystem(QString type)
 {
-    return (network_fs.contains(type) > 0);
+    return network_fs.contains(type);
 }
 
 void KMountMan::mainWindow()

With it, the Krusader builds fine and works well. But ff course, it wants the Krename.

BrunoLafleur · 05-14-2023, 01:10 PM

I have put the about-distro by default in KInfoCenter.

It needs a new version of the about-distro patch :
https://github.com/BrunoLafleur/pbsl...o-gpu.patch.gz

And a little patch in kde-workspace (no need to recompile packages which depends on it) :
https://github.com/BrunoLafleur/pbsl...enter.patch.gz
with :
https://github.com/BrunoLafleur/pbsl...orkspace.patch

For krusader I will look.

LuckyCyborg · 05-14-2023, 01:16 PM

Quote:

Originally Posted by BrunoLafleur

I have put the about-distro by default in KInfoCenter.

It needs a new version of the about-distro patch :
https://github.com/BrunoLafleur/pbsl...o-gpu.patch.gz

And a little patch in kde-workspace (no need to recompile packages which depends on it) :
https://github.com/BrunoLafleur/pbsl...enter.patch.gz
with :
https://github.com/BrunoLafleur/pbsl...orkspace.patch

For krusader I will look.

Great news!

BrunoLafleur · 05-14-2023, 01:16 PM

For krename it is in freetype2.

Try to add -I/usr/include/freetype2 in a cmake/krename file starting from a copy of cmake/cmake inside k4town.

I will test as soon I have time.

LuckyCyborg · 05-14-2023, 01:21 PM

Quote:

Originally Posted by BrunoLafleur

For krename it is in freetype2.

Try to add -I/usr/include/freetype2 in a cmake/krename file starting from a copy of cmake/cmake inside k4town.

I will test as soon I have time.

I will do.

BrunoLafleur · 05-14-2023, 01:35 PM

And a new snapshot of KInfoCenter.

LuckyCyborg · 05-14-2023, 01:55 PM

Quote:

Originally Posted by BrunoLafleur

For krename it is in freetype2.

Try to add -I/usr/include/freetype2 in a cmake/krename file starting from a copy of cmake/cmake inside k4town.

I will test as soon I have time.

well, in the end, this cmake/krename file did the trick

Code:

mkdir build
cd build
  cmake \
    $KDE_OPT_ARGS \
    -DKDE_PLATFORM_FEATURE_DISABLE_DEPRECATED=TRUE \
    -DCMAKE_PREFIX_PATH="/usr/lib${LIBDIRSUFFIX}/exiv221" \
    -DCMAKE_C_FLAGS:STRING="$SLKCFLAGS  -std=c++11 -I/usr/include/freetype2" \
    -DCMAKE_C_FLAGS_RELEASE:STRING="$SLKCFLAGS  -std=c++11 -I/usr/include/freetype2" \
    -DCMAKE_CXX_FLAGS:STRING="$SLKCFLAGS  -std=c++11 -fpermissive -I/usr/include/freetype2" \
    -DCMAKE_CXX_FLAGS_RELEASE:STRING="$SLKCFLAGS  -std=c++11 -fpermissive -I/usr/include/freetype2" \
    -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DMAN_INSTALL_DIR=/usr/man \
    -DSYSCONF_INSTALL_DIR=/etc/kde \
    -DLIB_SUFFIX=${LIBDIRSUFFIX} \
    ..

Many thanks for suggestion!

And in the attached screenshot, the KInfoCenter after rebuilding kde-workspace and about-distro with your latest patches.

So, I believe that this addition of about-distro was concluded successfully.

LuckyCyborg · 05-14-2023, 03:02 PM

So, there is the 6th upload of the kde4town of mine:

https://easyupload.io/m/c7rk48

As usual, this kde4town upload is split in 2 big tarballs for packages and sources, kde4town-packages-20230514.tar with the size of 1.07 GB and kde4town-source-20230514.tar with the size of 1.6 GB

These tarballs have the following SHA256 sums:

Code:

8623525e30e5d23ee53303d6b8502f334d9677ea6ff5fc61a2477e470eea1e69  kde4town-packages-20230514.tar
b96c28b9ddc9033b63f9a998358deb17d840777bf2713a0250e1f61943fb4e92  kde4town-source-20230514.tar

Please note that the packages directory structure was changed, now the packages built for Slackware 15.0 are on packages/15.0 while on packages/current are some additional packages reported to be required for kde4town's proper working under Slackware-current - in fact, there's today only a special build of jasper20 capable to be installed along with the stock jasper package from -current. Be warned that this jasper20 package is NOT needed for Slackware 15.0 .

As was requested, was added Krusader (and its friend Krename), and also was updated the libmm-qt, libnm-qt and plasma-nm packages from NetworkManager integration infrastructure, as of latest work of @BrunoLafleur.

Also, that new KCM module (seen discussed in the previous posts) named about-distro was added, with the kde-workspace patched along, and it gives a default page on KInfoCenter similar with the one from Plasma5.

Please note also that a new package named eigen20 was added, and the kdeedu:step was rebuilt along. In the end, I have arrived at conclusion that's simpler this way, because there may be another KDE4 software/packages depending on it.

Have fun!

cwizardone · 05-14-2023, 03:05 PM

Many thanks!
You are a gentleman and a scholar!

Edit in: installed and working as advertised.
Thanks, again, to LuckyCyborg and BrunoLafleur.