if else difficulty

Fixit7 · 01-12-2016, 09:19 PM

How do I get this to send time to file every 10 seconds ?

Quote:

#!/bin/bash
#
# Send date/time to file every 10 seconds
#
count=5
if [ $count == 5 ]
then
sleep 10
date "+ %m/%d/%y %r" >> date.txt
else
echo "Has not been 10 seconds"
fi

Fixit7 · 01-12-2016, 09:40 PM

This works.

Quote:

#!/bin/bash
#
# Linux Puppy 6.3.0
# SiegeWorks 2016 A.P.K.
#
# Send date/time ten times to file every 5 seconds
#
count=1
done=0

while [ $count -le 10 ]
do
sleep 1
(( count++ ))
if [ $count == 5 ]
then
continue
fi
sleep 5
date "+ %m/%d/%y %r" >> date.txt
done
echo Finished >> date.txt

berndbausch · 01-13-2016, 06:39 AM

If I may comment, although you seem to be happy....

A matter of style: If you use (( count++ )), why not if ((count<=10)) and if ((count==5))?

Also, it doesn't work. You write into date.txt roughly every 6 seconds, since

you first sleep a second,
then decide if you want to skip the rest of the loop (which you do only once, when the count reaches 5),
then sleep 5 seconds,
then record date and time.

Your code is somewhat complicated; is it supposed to so something else in addition to recording date/time?

Fixit7 · 01-13-2016, 07:13 AM

This is a latter edition that does something useful.

I will study your suggestions.

Quote:

#!/bin/bash
#
# Linux Puppy 6.3.0 SiegeWorks 2016 A.P.K.
#
# Send CPU temps to file every 15 minutes
# NOTE: This messes with icon for CPUtemp
count=1
done=0

while [ $count -le 10 ]
do
(( count++ ))
if [ $count == 5 ]
then
continue
fi
date "+ %m/%d/%y %r" >> ~/Documents/CPU_TEMPS.txt
sensors -f >> ~/Documents/CPU_TEMPS.txt
sleep 900
done

suicidaleggroll · 01-13-2016, 10:10 AM

Maybe I'm missing something, but why is this script so complicated? The "done" variable is never used, and what's the point of "count" causing the script to randomly skip the date/sensors part of the code on the 4th iteration of the while loop?

What was wrong with the original one? Why can't you just do:

Code:

#!/bin/bash

date "+ m/d/y %r" >> ~/Documents/CPU_TEMPS.txt
sensors -f >> ~/Documents/CPU_TEMPS.txt

And stick it in a cron job that runs every 15 minutes?

If you want any useful advice, you need to clarify what it is you're trying to do here.

Fixit7 · 01-13-2016, 10:14 AM

So, what do I need to do delete to eliminate the 4th iteration part ?

I am always in a state of learning and mistakes come with the territory.

I have used cron. Feel it is a little complicated.

Fixit7 · 01-13-2016, 10:15 AM

This needs work too.

Quote:

#!/bin/bash
#
# Linux Puppy 6.3.0 SiegeWorks 2016 A.P.K.
#
# Send battery state to file every 15 minutes
# Useful in determining how long your battery will actually last
#
count=1
done=0

while [ $count -le 10 ]
do
sleep 1
(( count++ ))
if [ $count == 5 ]
then
continue
fi
date "+ m/d/%y %r" >> Battery_State.txt
grep remaining /proc/acpi/battery/*/state >> Battery_State.txt
#
grep full /proc/acpi/battery/*/info >> Battery_State.txt
#
grep charging /proc/acpi/battery/*/state >> Battery_State.txt
sleep 900
done

suicidaleggroll · 01-13-2016, 10:45 AM

Again, you need to tell us what it is you're trying to do. Posting random code samples with NO explanation of what it's doing, what you expect it to be doing, what's good/bad about it, etc. is pointless.

Cron is one of the least complicated parts of Linux. You tell it when to run and what to run, what's complicated about that?

Fixit7 · 01-13-2016, 10:47 AM

Quote:

I put notes in my scripts.
Is it not clear what I am trying to do ?

# Send battery state to file every 15 minutes
# Useful in determining how long your battery will actually last

suicidaleggroll · 01-13-2016, 10:54 AM

And how are you running it? Why do you have a counter in there at all?

Fixit7 · 01-13-2016, 10:58 AM

Quote:

Originally Posted by suicidaleggroll

And how are you running it? Why do you have a counter in there at all?

I double click the bash script. Or I put it in startup dir.

Counter is so it does not run forever.

I would prefer that it only run until a certain time has been reached.

Like run for 3 hrs.

suicidaleggroll · 01-13-2016, 11:13 AM

Sounds like a pain to me, having to manually run it every time...
Either way, it sounds like you just need to get rid of that if statement that's checking count, it doesn't seem to serve any purpose.

Code:

#!/bin/bash

count=1

while [ $count -le 10 ]; do
   (( count++ ))
   date "+ m/d/y r" >> Battery_State.txt
   grep remaining /proc/acpi/battery/*/state >> Battery_State.txt
   grep full /proc/acpi/battery/*/info >> Battery_State.txt
   grep charging /proc/acpi/battery/*/state >> Battery_State.txt
   sleep 900
done

It would be simpler to just let it run all the time, automatically. Is there any particular reason you don't want it running all the time?

Code:

#!/bin/bash

date "+ m/d/y r" >> Battery_State.txt
grep remaining /proc/acpi/battery/*/state >> Battery_State.txt
grep full /proc/acpi/battery/*/info >> Battery_State.txt
grep charging /proc/acpi/battery/*/state >> Battery_State.txt

Then in cron:

Code:

*/15 * * * * /path/to/script

Fixit7 · 01-13-2016, 11:35 AM

Thanks.

In Puppy versions, any scripts in the root/Startup dir always start whenever computer is booted.

Date part of script is not working.

m/d/y r
remaining capacity: 2680 mAh
last full capacity: 3556 mAh
charging state: charging

suicidaleggroll · 01-13-2016, 11:37 AM

Sorry, that's a forum problem. For some reason "%" symbols get stripped out of posts. Just use what you already had:

Code:

date "+ %m/%d/%y %r" >> date.txt

Fixit7 · 01-13-2016, 11:42 AM

Thanks a lot.