LinuxQuestions.org
Welcome to the most active Linux Forum on the web.
Home Forums Tutorials Articles Register
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
Reload this Page [SOLVED] slackpkg-2.83.0-noarch-3 broke slackpkg+, sorry
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
Page 1 of 2 1 2
  Search this Thread
Old 06-15-2018, 02:34 AM   #1
zerouno
Member
 
Registered: Oct 2009
Location: Italy
Distribution: Slackware
Posts: 983

Rep: Reputation: 352Reputation: 352Reputation: 352Reputation: 352
slackpkg-2.83.0-noarch-3 broke slackpkg+, sorry

edit: slackpkg+-1.7.0-noarch-8mt.txz and slackpkg+-1.7.0d1-noarch-5mt.txz solve the issue.
You need to install it before slackpkg-2.83.0-3, or download and upgrade it manually from
http://slakfinder.org/slackpkg+/pkg/ or http://slakfinder.org/slackpkg+dev/



-------- was ----------

Before some other report it...,

Latest upgrade of slackpkg on current broke slackpkg+ sorry.

Code:
ap/slackpkg-2.83.0-noarch-3.txz:  Rebuilt.
  Don't remove ChangeLog.txt upon upgrade/reinstall.
  Use CHECKSUMS.md5.asc to determine if ChangeLog.txt is unchanged.
slackpkg+ is hugely based on the slackpkg 2.82.x, so I need some adjustment to fix it.


I hope to fix it as soon.
Last edited by zerouno; 06-16-2018 at 08:08 AM.
 
Old 06-15-2018, 02:45 AM   #2
linuxtinker
Member
 
Registered: Dec 2013
Location: NJ / USA
Distribution: Slackware 64 -Current
Posts: 232

Rep: Reputation: 99
Thanks for your work and the warning! I was in the middle of an upgrade when I read your other post.
 
Old 06-15-2018, 02:57 AM   #3
zerouno
Member
 
Registered: Oct 2009
Location: Italy
Distribution: Slackware
Posts: 983

Original Poster
Rep: Reputation: 352Reputation: 352Reputation: 352Reputation: 352
well... do not upgrade slackpkg for now if you want to continue to use slackpkg+
 
Old 06-15-2018, 03:52 AM   #4
chrisretusn
Senior Member
 
Registered: Dec 2005
Location: Philippines
Distribution: Slackware64-current
Posts: 2,979

Rep: Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556
Yikes! Just finished doing an update. Phew... still at slackpkg-2.83.0-noarch-1, the June 15 updates have not made it to the mirror I mirror from. My 1600 cron job, had nothing new. Will see it tomorrow, I will hold up with upgrading slackpkg. OH and thanks a million for slackpkg+, best thing since sliced bread and cold beer.

I knew slackpkg was not upgraded, just more fun to write it this way.
Last edited by chrisretusn; 06-15-2018 at 03:54 AM.
 
Old 06-15-2018, 04:27 AM   #5
linuxtinker
Member
 
Registered: Dec 2013
Location: NJ / USA
Distribution: Slackware 64 -Current
Posts: 232

Rep: Reputation: 99
I just tested the new slackpkg with slackpkg+ and it worked for me.. Where does it break for you??
 
Old 06-15-2018, 04:29 AM   #6
zerouno
Member
 
Registered: Oct 2009
Location: Italy
Distribution: Slackware
Posts: 983

Original Poster
Rep: Reputation: 352Reputation: 352Reputation: 352Reputation: 352
Please test attached patch.

# cd /usr/libexec/slackpkg/functions.d/
# patch -p0 < slackpkgplus-slackpkg283.diff.txt

before upgrade slackpkg backup the file /usr/libexec/slackpkg/core-functions.sh
If you need to redowngrade slackpkg restore that file without reinstall slackpkg 2.83.0-2

Code:
--- slackpkgplus.sh     2018-06-15 11:22:04.692308480 +0200
+++ slackpkgplus.sh     2018-06-14 09:14:10.150812814 +0200
@@ -472,23 +472,10 @@
     # The new getfile() download all file needed from all defined repositories
     # then merge all in a format slackpkg-compatible
   function getfile(){
-    if [ "$DOWNLOADCHANGELOG" = "force" -a $(basename $1) = "CHECKSUMS.md5.asc" ];then
-      echo "force to download ChangeLog"
-      DOWNLOADCHANGELOG=no
-      getfile "$(echo "$1"|sed 's/CHECKSUMS.md5.asc$/ChangeLog.txt/')" "$(echo "$2"|sed 's/CHECKSUMS.md5.asc$/ChangeLog.txt/')"
-      >$TMPDIR/changelogdownloaded
-      echo "PGP" >$TMPDIR/CHECKSUMS.md5.asc
-      return
-    fi
     local URLFILE
     URLFILE=$1
 
     if [ $(basename $1) = "ChangeLog.txt" ];then
-      if [ -e $TMPDIR/changelogdownloaded ];then
-       echo "                Done."
-       return
-      fi
-      rm -f $TMPDIR/CHECKSUMS.md5.asc
       echo "                ChangeLogs"
     fi
 
@@ -1612,7 +1599,6 @@
     # answer to "Do you really want to download all other files"
     # if there are new changes
     ANSWER="Y"
-    DOWNLOADCHANGELOG=force
   fi
 
   if [ "$UPARG" != "gpg" ]&&[ "$CHECKGPG" = "on" ]&& ! ls -l $WORKDIR/gpg/GPG-KEY-slackware*.gpg >/dev/null 2>&1;then

edit: note that I've tested this patch with only the development version o slackpkg+ but it should work (with warning) on slackpkg stable.

Also there is some regression in slackpkg check-updates not solved by that patch.
Attached Files
File Type: txt slackpkgplus-slackpkg283.diff.txt (1.2 KB, 27 views)
Last edited by zerouno; 06-15-2018 at 05:06 AM.
 
Old 06-15-2018, 05:33 AM   #7
Darth Vader
Senior Member
 
Registered: May 2008
Location: Romania
Distribution: DARKSTAR Linux 2008.1
Posts: 2,727

Rep: Reputation: 1247Reputation: 1247Reputation: 1247Reputation: 1247Reputation: 1247Reputation: 1247Reputation: 1247Reputation: 1247Reputation: 1247
@zerouno

I had never touched that SLACKPKG thing in my entire life, BUT maybe I have a suggestion for you.

So, as I read in another threads, our BDFL is focused right now (also) in a better handling of ChangeLog.txt by SLACKPKG, to avoid its entire downloading if possible...

You do not think you need to implement a similar mechanism on your extension?
Last edited by Darth Vader; 06-15-2018 at 05:40 AM.
 
Old 06-15-2018, 05:43 AM   #8
zerouno
Member
 
Registered: Oct 2009
Location: Italy
Distribution: Slackware
Posts: 983

Original Poster
Rep: Reputation: 352Reputation: 352Reputation: 352Reputation: 352
Thanks for suggest.

currently slackpkg+ allow a caching system (disabled by default).

By setting CACHEUPDATE=on
slackpkg avoid to redownload the changelog and any other files if they are not changed

It's the same that slackpkg-2.83.0-3 does now by downloading the CHECKSUMS.md5.asc (just few bytes) now.


However this is an emergency patch.
Next stable release may contain some other features.
 
Old 06-15-2018, 08:26 AM   #9
DaBrze
LQ Newbie
 
Registered: Mar 2018
Location: Lodz, PL
Distribution: Slackware
Posts: 16

Rep: Reputation: Disabled
@zerouno

I have checked the patch on my productive system with slackpkg+-1.7.0-noarch-6mt.txz installed. I have modified it like below (slackpkgplus.sh.diff). Then it works OK.

# cd /usr/libexec/slackpkg/functions.d/
# patch -p0 slackpkgplus.sh < slackpkgplus.sh.diff


Quote:
456a457,465
> if [ "$DOWNLOADCHANGELOG" = "force" -a $(basename $1) = "CHECKSUMS.md5.asc" ];then
> echo "force to download ChangeLog"
> DOWNLOADCHANGELOG=no
> getfile "$(echo "$1"|sed 's/CHECKSUMS.md5.asc$/ChangeLog.txt/')" "$(echo "$2"|sed 's/CHECKSUMS.md5.asc$/ChangeLog.txt/')"
> >$TMPDIR/changelogdownloaded
> echo "PGP" >$TMPDIR/CHECKSUMS.md5.asc
> return
> fi
>
582a592,596
> if [ -e $TMPDIR/changelogdownloaded ];then
> echo " Done."
> return
> fi
> rm -f $TMPDIR/CHECKSUMS.md5.asc
1566a1581
> DOWNLOADCHANGELOG=force
 
Old 06-15-2018, 09:00 AM   #10
zerouno
Member
 
Registered: Oct 2009
Location: Italy
Distribution: Slackware
Posts: 983

Original Poster
Rep: Reputation: 352Reputation: 352Reputation: 352Reputation: 352
thankyou.

please, use 'diff -u' to generate a patch, and use the '[code]' tag to post it.
 
Old 06-15-2018, 10:07 AM   #11
Olek
Member
 
Registered: Jul 2012
Location: Wroclaw Poland
Distribution: Slackware
Posts: 110

Rep: Reputation: 27
Quote:
Originally Posted by zerouno View Post
Please test attached patch.

# cd /usr/libexec/slackpkg/functions.d/
# patch -p0 < slackpkgplus-slackpkg283.diff.txt

edit: note that I've tested this patch with only the development version o slackpkg+ but it should work (with warning) on slackpkg stable.

Also there is some regression in slackpkg check-updates not solved by that patch.
# patch -p0 < slackpkgplus-slackpkg283.diff.txt
patching file slackpkgplus.sh
Hunk #1 FAILED at 472.
Hunk #2 FAILED at 1612.
2 out of 2 hunks FAILED -- saving rejects to file slackpkgplus.sh.rej

Code:
--- slackpkgplus.sh     2018-06-15 11:22:04.692308480 +0200
+++ slackpkgplus.sh     2018-06-14 09:14:10.150812814 +0200
@@ -472,23 +472,10 @@
     # The new getfile() download all file needed from all defined repositories
     # then merge all in a format slackpkg-compatible
   function getfile(){
-    if [ "$DOWNLOADCHANGELOG" = "force" -a $(basename $1) = "CHECKSUMS.md5.asc" ];then
-      echo "force to download ChangeLog"
-      DOWNLOADCHANGELOG=no
-      getfile "$(echo "$1"|sed 's/CHECKSUMS.md5.asc$/ChangeLog.txt/')" "$(echo "$2"|sed 's/CHECKSUMS.md5.asc$/ChangeLog.txt/')"
-      >$TMPDIR/changelogdownloaded
-      echo "PGP" >$TMPDIR/CHECKSUMS.md5.asc
-      return
-    fi
     local URLFILE
     URLFILE=$1

     if [ $(basename $1) = "ChangeLog.txt" ];then
-      if [ -e $TMPDIR/changelogdownloaded ];then
-       echo "                Done."
-       return
-      fi
-      rm -f $TMPDIR/CHECKSUMS.md5.asc
       echo "                ChangeLogs"
     fi

@@ -1612,7 +1599,6 @@
     # answer to "Do you really want to download all other files"
     # if there are new changes
     ANSWER="Y"
-    DOWNLOADCHANGELOG=force
   fi

   if [ "$UPARG" != "gpg" ]&&[ "$CHECKGPG" = "on" ]&& ! ls -l $WORKDIR/gpg/GPG-KEY-slackware*.gpg >/dev/null 2>&1;then
I use slackpkg+-1.7.0-noarch-6mt
Attached Files
File Type: txt slackpkgplus.sh.rej.txt (1.2 KB, 10 views)
 
Old 06-15-2018, 10:36 AM   #12
zerouno
Member
 
Registered: Oct 2009
Location: Italy
Distribution: Slackware
Posts: 983

Original Poster
Rep: Reputation: 352Reputation: 352Reputation: 352Reputation: 352
slackpkg+-1.7.0-noarch-7mt.txz and slackpkg+-1.7.0d1-noarch-4mt.txz released

- Fix incompatibility with slackpkg-2.83.0-noarch-3


Thanks for testing.
 
Old 06-15-2018, 11:34 AM   #13
zerouno
Member
 
Registered: Oct 2009
Location: Italy
Distribution: Slackware
Posts: 983

Original Poster
Rep: Reputation: 352Reputation: 352Reputation: 352Reputation: 352
I'm sorry...

this fix broke compatibility with versione PRIOR slackpkg-2.83.0-3 (included slackpkg from slackware stable)

slackpkg+-1.7.0-noarch-8mt.txz
slackpkg+-1.7.0d1-noarch-5mt.txz

will solve
 
Old 06-15-2018, 10:05 PM   #14
chrisretusn
Senior Member
 
Registered: Dec 2005
Location: Philippines
Distribution: Slackware64-current
Posts: 2,979

Rep: Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556Reputation: 1556
Quote:
Originally Posted by zerouno View Post
I'm sorry...

this fix broke compatibility with versione PRIOR slackpkg-2.83.0-3 (included slackpkg from slackware stable)

slackpkg+-1.7.0-noarch-8mt.txz
slackpkg+-1.7.0d1-noarch-5mt.txz

will solve
Sorry I missed the patches fun earlier, was sawing logs, so says my wife anyway. Got the update this morning on running slackpkg update. Manually refreshed my local slackware64-current mirror (scheduled for 1600 its 1020 now) and tested, no issues.
 
Old 06-16-2018, 06:31 AM   #15
mlangdn
Senior Member
 
Registered: Mar 2005
Location: Kentucky
Distribution: Slackware64-current
Posts: 1,845

Rep: Reputation: 452Reputation: 452Reputation: 452Reputation: 452Reputation: 452
I can't seem to import 3rd party gpg keys:

Code:
==============================================================================
    WARNING! One or more errors occurred while slackpkg was running
------------------------------------------------------------------------------
Repository 'alienbob' FAILS the CHECKSUMS.md5 signature check.
Try to run 'slackpkg update gpg'

Repository 'slackpkgplus' FAILS the CHECKSUMS.md5 signature check.
Try to run 'slackpkg update gpg'

Repository 'restricted' FAILS the CHECKSUMS.md5 signature check.
Try to run 'slackpkg update gpg'

Try to run 'slackpkg update gpg'

This is what I see after importing gpg keys:

Code:
bash-4.4# slackpkg update gpg

2018-06-16 06:20:18 URL: ftp://ftp.osuosl.org/.2/slackware/slackware64-current/GPG-KEY [1572] -> "/tmp/slackpkg.Gjzmq4/gpgkey" [1]
pub  1024D/40102233 2003-02-26 Slackware Linux Project <security@slackware.com>
sub  1024g/4E523569 2003-02-26 [expires: 2038-01-19]

2018-06-16 06:20:19 URL:http://bear.alienbase.nl/mirrors/people/alien/sbrepos/current/x86_64/GPG-KEY [17372/17372] -> "/tmp/slackpkg.Gjzmq4/gpgkey-tmp-alienbob" [1]
pub  1024D/A75CBDA0 2003-01-17 Eric Hameleers <alien@slackware.com>
uid                            Eric Hameleers (IBM Linux) <alien@linux.vnet.ibm.com>
uid                            Eric Hameleers (Thuis) <e.hameleers@chello.nl>
uid                            Eric Hameleers (IBM Linux) <alien@nl.ibm.com>
uid                            Eric Hameleers <eric.hameleers@int.greenpeace.org>
uid                            Eric Hameleers <alien@sox.homeip.net>
uid                            [jpeg image of size 3054]
uid                            Eric Hameleers (SBo) <alien@slackbuilds.org>
uid                            Eric Hameleers <eric.hameleers@alienbase.nl>
sub  1792g/7CBDC819 2003-01-17
gpg: key A75CBDA0: "Eric Hameleers <alien@slackware.com>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1


2018-06-16 06:20:20 URL:http://slakfinder.org/slackpkg+/GPG-KEY [1805/1805] -> "/tmp/slackpkg.Gjzmq4/gpgkey-tmp-slackpkgplus" [1]
pub  2048R/ED123FBC 2011-01-01 Matteo Rossini <zerouno@slacky.it>
sub  2048R/2B41569A 2011-01-01
gpg: key ED123FBC: "Matteo Rossini <zerouno@slacky.it>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1


2018-06-16 06:20:20 URL:http://bear.alienbase.nl/mirrors/people/alien/restricted_sbrepos/current/x86_64/GPG-KEY [17372/17372] -> "/tmp/slackpkg.Gjzmq4/gpgkey-tmp-restricted" [1]
pub  1024D/A75CBDA0 2003-01-17 Eric Hameleers <alien@slackware.com>
uid                            Eric Hameleers (IBM Linux) <alien@linux.vnet.ibm.com>
uid                            Eric Hameleers (Thuis) <e.hameleers@chello.nl>
uid                            Eric Hameleers (IBM Linux) <alien@nl.ibm.com>
uid                            Eric Hameleers <eric.hameleers@int.greenpeace.org>
uid                            Eric Hameleers <alien@sox.homeip.net>
uid                            [jpeg image of size 3054]
uid                            Eric Hameleers (SBo) <alien@slackbuilds.org>
uid                            Eric Hameleers <eric.hameleers@alienbase.nl>
sub  1792g/7CBDC819 2003-01-17
gpg: key A75CBDA0: "Eric Hameleers <alien@slackware.com>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1

                        Slackware Linux Project's GPG key added
And lastly, this bit:

Code:
bash-4.4# ==============================================================================
bash: ==============================================================================: command not found
bash-4.4#   WARNING! One or more errors occurred while slackpkg was running
bash: WARNING!: command not found
bash-4.4# ------------------------------------------------------------------------------
bash: ------------------------------------------------------------------------------: command not found
bash-4.4# Repository 'alienbob' FAILS the CHECKSUMS.md5 signature check.
bash: Repository: command not found
bash-4.4# Try to run 'slackpkg update gpg'
bash: Try: command not found
bash-4.4# 
bash-4.4# Repository 'slackpkgplus' FAILS the CHECKSUMS.md5 signature check.
bash: Repository: command not found
bash-4.4# Try to run 'slackpkg update gpg'
bash: Try: command not found
bash-4.4# 
bash-4.4# Repository 'restricted' FAILS the CHECKSUMS.md5 signature check.
bash: Repository: command not found
bash-4.4# Try to run 'slackpkg update gpg'
bash: Try: command not found
 
  


Reply
Page 1 of 2 1 2



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] latest slackpkg broke update? qunying Slackware 2 05-31-2018 05:26 PM
having trouble after upgrading 14.1 slackware using slackpkg and slackpkg+ [solved] slackartist Slackware 1 12-28-2015 07:28 AM
[SOLVED] Slackpkg, Slackpkg Plus, Slackware 14.1 x86_64 install.log delay or slow to write bamunds Slackware 7 04-22-2014 11:12 AM
[SOLVED] typos in latest /etc/slackpkg/mirrors(.new) [slackpkg-2.82.0-noarch-8.tgz] wailingwailer Slackware 4 09-22-2012 04:04 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 06:27 AM.

Contact Us - Advertising Info - Rules - Privacy - LQ Merchandise - Donations - Contributing Member - LQ Sitemap -
Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration