My script does not work properly, what is wrong?

lancsuk · 03-04-2021, 03:50 AM

Quote:

Originally Posted by pan64

what I don't understand:
you do not need to put it into .bash_profile, you can do the following:

Code:

###### original
# if [ ! -d $LPATH ]; then
# 	mkdir -p $LPATH
# 	echo 'export PATH=\$PATH:$LPATH >> $HOME/.bash_profile'
# 	source $HOME/.bash_profile
# fi

##### new
mkdir -p $LPATH
export PATH=$PATH:$LPATH

Obviously you can put it into .bash_profile if you wish, but not really required for this script.

Your are absolutely right, bash_profile isn't really required for the script.

igadoter · 03-04-2021, 04:25 AM

How often do you plan to install xmonad? You are creating script you will possibly using once at all. Then you will be updating xmonad. I am not specialist but I understand that git allows to provide easy updates from source tree. This is why your script does not work. It is not a tool but exercise from bash scripting. Just post in Programming subforum. Someone possibly will explain to you why it is not correct bash script. Possibly your aim is to share your script among xmonad users? Good luck.

blancamolinos · 03-04-2021, 06:45 AM

It is possible that at the beginning of the script .bash_profile there is a check to verify if the shell is interactive as it appears in this link

https://stackoverflow.com/questions/...pt-not-working

lancsuk · 03-05-2021, 12:10 AM

Quote:

Originally Posted by igadoter

How often do you plan to install xmonad? You are creating script you will possibly using once at all. Then you will be updating xmonad. I am not specialist but I understand that git allows to provide easy updates from source tree. This is why your script does not work. It is not a tool but exercise from bash scripting. Just post in Programming subforum. Someone possibly will explain to you why it is not correct bash script. Possibly your aim is to share your script among xmonad users? Good luck.

Basically it was just a request from a number of Xmonad users and a good moment to improve my scripting skills.

By the way, the script works, but I expected a bit more. But that is all right.