Hey guys,

I am new to scripting but I think this is an easy question.

In the script below I think I have the second line wrong. Is there a better way to write this? I am trying to discover all vmx files, then register each one. I have it getting the state right now until I can work out the "for vm in $findvm" part.

Your help is greatly appreciated!


#!/bin/bash

findvm="find /vmfs/volumes -name *.vmx"
for vm in $findvm
do vmware-cmd "$vmx" getstate
done
exit



Respectfully,

just in case I wasn't clear.

I want to collect a bunch of names of servers (server1.vmx, server2.vmx, etc.)

Then I want to use that next line to take that list of servers and get the power state.

I am getting an error when I run the current script and I believe I am not using the right syntax in that second line to get the program to take that list and get the power state for each found server.vmx.

Your help is greatly appreciated!

Respectfully,

You're right, second line:

for i in $findvm;

else do and so on is regarded as other words to iterate $i over.

I think that would be a better way of doing it, but isn't the problem with the original script the first line which should be As I understand it using quotes would make the for loop iterate over the words "find", then "/vmfs/volumes", and so on.

And you probably meant

Oops, took " for ` when glancing through...

Raskin and ntubski, you help is invaluable, thank you so much!

So here is what I have now:


#!/bin/bash
find /vmfs/volumes -name '*.vmx' -exec vmware-cmd "{}" getstate \;
done
exit


This seems to be working much better. The output looks like this:


getstate() = off
getstate() = off
getstate() = on
getstate() = off


How do I get it to list the servername and then the state, for example:

server1.vmx = off

Second question, is that done need to be there or is there better syntax for it? When I ran the program it ended like this:

./tryimprove.vbs: line 3: syntax error near unexpected token `done'
./tryimprove.vbs: line 3: `done'
[root@ESX MattsMadDatastore]# getstate() = off
-bash: syntax error near unexpected token `='
[root@ESX MattsMadDatastore]# getstate() = on
-bash: syntax error near unexpected token `='
[root@ESX MattsMadDatastore]# getstate() = off
-bash: syntax error near unexpected token `='
[root@ESX MattsMadDatastore]# getstate() = off


Respectfully,
Matthew

``done'' was needed as a pair for ``do'' when you used ``for''. Surely, now only
is needed.
I would make one more script to do something like
vmware-cmd "$1" getstate | sed -e 's/^getstate[(][)]/'"$1"'/'
and put it instead vmware-cmd in your script.