Shell Scripting Problem: command not found

gods_design · 02-10-2009, 09:14 PM

I am writing a small script to check my public ip against a php page I host and then if the ip has changed it will trigger an update in some files. When I run the script it gives me the error "command not found"

Here is the code:

Code:

#!/usr/local/bin/bash

OLD_IP=`cat /tmp/currentip`
CURRENT_IP=`curl -s http://toomanymiles.net/publicip.php`

if ["$CURRENT_IP" == "$OLD_IP"]
then 
        echo "IP Current"
else
        echo $CURRENT_IP > /tmp/currentip
        echo "IP Updated!"
fi

The output I get is:

Code:

-bash-3.2$ ./checkip.sh 
./checkip.sh: line 6: [77.29.41.58: command not found
IP Updated!

I know it is probably something simple but I can't figure out what I am doing wrong.

wje_lq · 02-10-2009, 09:50 PM

Change

Code:

if ["$CURRENT_IP" == "$OLD_IP"]

to

Code:

if [ "$CURRENT_IP" == "$OLD_IP" ]

Believe it or not, this works because

Code:

is actually a command, and it is equivalent to

Code:

test

If you jam the IP address right up against the [, you'll get an entirely different (and nonexistent, as you found out) command.

Hope this helps.

alan_ri · 02-10-2009, 09:53 PM

Ignore this post.

gods_design · 02-10-2009, 11:58 PM

Just when I thought i had tried everything. Thank you that worked great.

Quote:

Originally Posted by wje_lq

Change

Code:

if ["$CURRENT_IP" == "$OLD_IP"]

to

Code:

if [ "$CURRENT_IP" == "$OLD_IP" ]

Believe it or not, this works because

Code:

is actually a command, and it is equivalent to

Code:

test

If you jam the IP address right up against the [, you'll get an entirely different (and nonexistent, as you found out) command.

Hope this helps.