Script to dump and restore rrd files

0.o · 12-21-2007, 02:39 PM

I was wondering if someone could point me in the right direction with this script.

Code:

#!/bin/sh
set -x
case "$1" in
        dump)
                Dump()
                exit
                ;;
        import)
                xmlimport
                exit
                ;;
        *)
                echo "nothing"
                exit
                ;;
esac

Dump()
{
        for rrd in `find . -type f -name "*.rrd"`
                do
                        xml=`echo $rrd | sed 's/.rrd//g'`

                        rrdtool dump $rrd > $xml
                done
}

xmlimport()
{
        for xml in `find . -type f -name "*.xml"`
        do
                rrd=`echo $xml | sed 's/.xml//g'`

                rrdtool restore $xml $rrd

                rm $xml
        done
}

I am not really used to using functions in my scripts and am trying to get used to doing so. I can use the for loops without a function and it work fine. Please advise. Thanks!!

gnashley · 12-21-2007, 03:20 PM

You need to put the functions before the case statement in the file. Shell functions must be read in first so that they are available when called.

0.o · 12-31-2007, 12:07 PM

Yeah, i had a brain fart when i wrote that. Here is the finished script if anyone wants it:

Code:

#!/bin/sh

ECHO="echo -e"

rrdump ()
{
	for rrd in `find . -type f -name "*.rrd"`
		do
			xml=`echo $rrd | sed 's/.rrd//g'`
			rrdtool dump $rrd > $xml.xml
			rm $rrd
		done
}	

xmlimport ()
{
	for xml in `find . -type f -name "*.xml"`
        do
                rrd=`echo $xml | sed 's/.xml//g'`
                rrdtool restore $xml $rrd.rrd
                rm $xml
        done
}


case "$1" in
        dump)
                rrdump
		;;
        import)
                xmlimport
                ;;
        *)
                $ECHO "$0 takes one of two arguments\n"
		$ECHO "$0 dump -- dumps contents to xml\n"
		$ECHO "$0 import -- imports xml files to rrd\n"
                ;;
esac

If executed at the top of the directory with the rrd files, i will search through and dump all rrd files to xml and preserve the path. It will do the same for xml -> rrd.