python code syntax error

plymouth72 · 02-22-2018, 08:25 PM

Hello:
I'm new in this forum as with Linux as well. I'm trying to set up an instant reply system using a raspberri pi3 and the pi camera. I already have the main stuff done, but with the code I will need some help from you guys!
This code is already in youtube https://www.youtube.com/watch?v=-QyMxKfBaAE from a guy that use it for the same pourpose that me. My problem is at the moment of run the code in the cmd prompt. there is a syntax error message specifically in the line #42

while not dircreated: if os.path.exists(directory): #add suffix and check again dirsuf = dirsuf + 1 directory = dirpref + "/" + str(dirsuf) + "/" else: #create directory os.makedirs(directory) dircreated = True
camera.start_preview()

here is the complete code in case someone of you can revise it and tell me what is wrong with it.

Code:

import sys
import io
import picamera
import RPi.GPIO as GPIO
import time
import os
from subprocess import Popen
import pygame.display
import pygame.event
#Set up confirguration
isoVal = 0
expmode = 'sports'
postseconds = 1.0
totalseconds = 1.5
thisframerate = 90
playbackframerate = 15
theoplaytime = totalseconds * thisframerate / playbackframerate
firstsleep = theoplaytime + 1
secsleep = firstsleep + 5
#set blank screen behind everything
pygame.display.init()
screen = pygame.display.set_mode((0, 0), pygame.FULLSCREEN)
screen.fill((0, 0, 0))
#set up GPIO using BCM Numbering
GPIO.setmode(GPIO.BCM)
GPIO.setup(5, GPIO.IN)
camera = picamera.PiCamera()
camera.vflip = True
camera.hflip = True
camera.resolution = (640, 480)
camera.framerate = thisframerate
camera.exposure_mode = 'sports'
camera.iso = isoVal
stream = picamera.PiCameraCircularIO(camera, seconds=7)
camera.start_recording(stream, format='h264', intra_period = 10)
videocount = 1
#set up directory for files
dirpref = time.strftime("%b%d%y")
directory = dirpref + "/"
dircreated = False
dirsuf = 0
while not dircreated: if os.path.exists(directory): #add suffix and check again dirsuf = dirsuf + 1 directory = dirpref + "/" + str(dirsuf) + "/" else: #create directory os.makedirs(directory) dircreated = True
camera.start_preview()
running = True
try: while running: for event in pygame.event.get(): if (event.type == pygame.KEYUP and event.key == pygame.K_c and event.mod & pygame.KMOD_CTRL): pygame.quit() sys.exit() camera.wait_recording(0.2) if GPIO.input(5): camera.wait_recording(postseconds) filemp4 = directory + "race" + str(videocount) + ".mp4" filename = directory + "race" + str(videocount) + ".h264" stream.copy_to(filename, seconds=totalseconds) convertstring = "MP4Box -fps " + str(playbackframerate) + " -add " + filename + " " + filemp4 #playerstring = "omxplayer " + filemp4 os.system(convertstring) #os.system(playerstring) omxc = Popen(['omxplayer', filemp4]) camera.stop_preview() time.sleep(firstsleep) omxc = Popen(['omxplayer', filemp4]) videocount = videocount + 1 time.sleep(secsleep) camera.start_preview()




finally: pygame.display.quit() GPIO.cleanup() camera.stop_recording() camera.stop_preview() camera.close() sys.exit()

Appreciate your help!!

ntonio Caban
removed

rtmistler · 02-23-2018, 06:51 AM

Hi, I've moved your question to the Programming forum to gain it better exposure.

I've also removed your personal email. The intents of the LQ site are that your questions are public and so are the answers so that others may benefit from seeing you work out the solution to your problem, much like the reference link you found to gain this code and start with your efforts.

Finally, I've added [code][/code] tags around your code to place it within a code block. This helps to retain the formatting. Meanwhile the formatting is likely gone when you pasted it inline. If you wish you can edit your original post to past in the code to recover the spacing and formatting.

Sorry I don't have a solution to propose, however my experience with the members from the Programming forum is that they likely will have a great deal of suggestions to help you with your syntax error and the remainder of your problem.

Best Regards, and welcome to LQ.

pan64 · 02-23-2018, 07:59 AM

it looks like python code and it is not formatted properly.
I don't know if it just the post here or what you tried to execute.

where is this code from (exactly)?

jlinkels · 02-23-2018, 09:17 AM

Python code is indent sensitive. You have to format it properly for it to work.

jlinkels

rtmistler · 02-23-2018, 09:23 AM

The OP did an inline paste of their code. All indenting was lost. I added the code block around it, however could not restore any formatting because none was in there as it was. We'll have to await their update to see if they can edit or post a new reply with properly formatted code inside code blocks.

teckk · 02-23-2018, 09:30 AM

That's a mess, the format anyway.

Code:

>>> import time
>>> dirpref = time.strftime("%b%d%y")
>>> print (dirpref)
Feb2318
>>> directory = dirpref + "/"
>>> print (directory)
Feb2318/
>>> dircreated = False
>>> import os
>>> while not dircreated:
...     if os.path.exists(directory):
...             print ("yes")
...     else:
...             print ("no")
no

Clean that up, so that you can see what you are doing

Code:

while not dircreated:
    if os.path.exists(directory):
        do something
    else:
        do something else
        
#Something like:        
while not dircreated: 
    if os.path.exists(directory): #add suffix and check again 
        dirsuf = dirsuf + 1 
        directory = dirpref + "/" + str(dirsuf) + "/" 
    else: 
        os.makedirs(directory) dircreated = True #create directory
camera.start_preview()

Also you can't put remarks at the front of a line like that.
You'll remark the whole line.

Check your code in python shell as you go.

Code:

>>> dirsuf = 0
>>> dirsuf = dirsuf + 1
>>> print (dirsuf)
1
>>> directory = dirpref + "/" + str(dirsuf) + "/"
>>> print (directory)
Feb2318/1/

plymouth72 · 02-24-2018, 03:55 PM

thanks to every one that spend some time trying to help me.
A i said before, i' m not experinced with linix and sorry for the mess withe code.
I just copy and paste it from the youtube link where I found it.
so formating means to break the lines as you guysmention above?
Can someone re write the whole code as it should be to see if it works?
thanks for the time of all of youguys and ! que viva el hobbie!!!😆🚀

astrogeek · 02-25-2018, 01:38 AM

Asking others to rewrite and test code that you have downloaded from some random place on the interwebs is not appropriate here at LQ. Please review the Site FAQ for guidance in posting your questions and general forum usage.

Python code depends on correct indentation as a core part of its "meaning". Multiple examples of code, identical except for the way they are indented, may all run but will produce different results. As no one here can say how the original author intended it to be indented, no one can offer useful help for oyur question.

I would suggest that you return to the place you got the code and ask for help, or at least try to get a working code example.

Good luck!

floppy_stuttgart · 02-25-2018, 01:58 PM

If you pay a girl/guy here 300$ per hour, they will work for you. Else, ask for a kindly help for some details. (My recommendation since I spent already few hours in that nice forum.)