Perl - foreach loop reading only the last $scalar in a @list

OldGaf · 08-07-2009, 07:28 PM

Hi all..... as a means of learning Perl, I am writing a script to search for files of various extensions. Here is a little snippet to show you my issue. The output shows that only files ending in "txt" are being found.... am I over writing @files every time thus only the last $ext survives? If so, how should the script read to put all file paths of all types in @type into @files.

lol... sorry if this makes no scene.... been a VERY long day.. time for bed!

Quote:

#!/usr/bin/perl -w

use File::List;

my @type = ("html", "mp3", "txt");

foreach $ext (@type) {
$search = new File::List("/home/mine");
@files = @{ $search->find("\.$ext\$")};
}

print "\n\n";
foreach $file (@files) {
print "$file\n";
}

print "\n\n";
foreach $ext (@type) {
print "$ext\n";
}

Output is:

Quote:

/home/mcy/.mozilla/firefox/wkidzzc0.default/cert_override.txt
/home/mcy/.mozilla/firefox/wkidzzc0.default/signons3.txt
/home/mcy/.mozilla/firefox/wkidzzc0.default/urlclassifierkey3.txt
/home/mcy/readme.txt

html
mp3
txt

gregorian · 08-08-2009, 12:13 AM

Try this? It appears like you're overwriting your previous search results with the last one.

Code:

#!/usr/bin/perl -w

use File::List;

my @type = ("html", "mp3", "txt");

foreach $ext (@type) {
$search = new File::List("/home/mine");
@files = @{ $search->find("\.$ext\$")};

print "$ext\n";

print "\n\n";
foreach $file (@files) {
print "$file\n";
}

}

OldGaf · 08-08-2009, 09:23 AM

Quote:

Originally Posted by gregorian

Try this? It appears like you're overwriting your previous search results with the last one.

Code:

#!/usr/bin/perl -w

use File::List;

my @type = ("html", "mp3", "txt");

foreach $ext (@type) {
$search = new File::List("/home/mine");
@files = @{ $search->find("\.$ext\$")};

print "$ext\n";

print "\n\n";
foreach $file (@files) {
print "$file\n";
}

}

Thanks gregorian,

Things are looking much clearer this morning!

The idea would be to have everything in one list, but I can append it to something like @total on each pass (minus the info from @type)...... thanks for the help!

OldGaf · 08-08-2009, 09:57 AM

This works fine...... thanks again!

Quote:

#!/usr/bin/perl -w

use File::List;

my @type = ("html", "mp3", "txt");

my @total=();

foreach $ext (@type) {
$search = new File::List("/home/mine");
@files = @{ $search->find("\.$ext\$")};

push(@total, @files);

}