[SOLVED] Multiple Input in bash

TashiDuks · 12-15-2016, 03:06 AM

Hi,

I have a configuration file (mymy.conf) with following values:

ftp.enabled: true,
http.enabled: false,
rdp.enabled: false,
smb.enabled: true

and so on ...

I want to write a script where the above values would be set to "true" or "false" one by one.

For example: Filename:

Do you want to enable FTP? [Y/N] : y
Do you want to enable HTTP? [Y/N] : y
Do you want to enable RDP? [Y/N] : n
Do you want to enable SMB? [Y/N] :y
... so on till the end

I tried to used following code using multiple case but there is an issue:

Code:

#Enable/Disable PORTS [Ports]
				
				#===>FTP
                                read -p "Do you want to enable FTP Port? [y/N]" responseFTP
                                case "$responseFTP" in
                                        y|Y )
                                                #Enable
                                                sudo sed -i 's/\("ftp.enabled":\).*/\1 'true',/' mymy.conf ;;
                                        n|N )
                                                sudo sed -i 's/\("ftp.enabled":\).*/\1 'false',/' mymy.conf ;;
                                        * )     echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m " ;;
                                esac;;
				 #===>HTTP
                                read -p "Do you want to enable HTTP Port? [y/N]" responseHTTP
                                case "$responseHTTP" in
                                        y|Y )
                                                #Enable
                                                sudo sed -i 's/\("http.enabled":\).*/\1 'true',/' mymy.conf ;;
                                        n|N )
                                                sudo sed -i 's/\("http.enabled":\).*/\1 'false',/' mymy.conf ;;
                                        * )     echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m " ;;
                                esac;;

Is there any easier way?

Thanks

TenTenths · 12-15-2016, 03:47 AM

Quote:

Originally Posted by TashiDuks

Is there any easier way?

Yes.

Use looping.

Code:

for OPTION in ftp http rdp smb ; do
  read -p "Do you want to enable ${OPTION} Port? [y/N]" RESPONSE
  case "${RESPONSE}" in
    y|Y )
      #Enable
      sudo sed -i 's/\("${OPTION}.enabled":\).*/\1 'true',/' mymy.conf ;;
    n|N )
      sudo sed -i 's/\("${OPTION}.enabled":\).*/\1 'false',/' mymy.conf ;;
    * )     echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m " ;;
  esac;;
done

pan64 · 12-15-2016, 05:24 AM

you can also try to read the available options:

Code:

for OPTION in $(awk -F. '{print $1}' mymy.conf);
do
    ...
done

grail · 12-15-2016, 08:41 AM

I would also force case on your test variable so you do not have to worry how the user inputs the information:

Code:

read -p "Do you want to enable ${OPTION} Port? [y/N]" RESPONSE
  case "${RESPONSE^}" in
    Y)...
    N)...

Also, TenTenths' example is fine but you will need to rework the quotes for the variables to work in the sed.

As usual, you only present a snippet of this imaginary conf file you keep using as an example, so I believe the seds can probably be made a lot simpler but would be unable to assist unless we get a better idea
of the original file.

TenTenths · 12-15-2016, 08:44 AM

Quote:

Originally Posted by grail

Also, TenTenths' example is fine but you will need to rework the quotes for the variables to work in the sed.

Yeah, to be honest I dashed it out before my first coffee, so caveat emptor, YMMV, etc.

TashiDuks · 12-15-2016, 10:23 PM

Quote:

Originally Posted by TenTenths

Yes.

Use looping.

Code:

for OPTION in ftp http rdp smb ; do
  read -p "Do you want to enable ${OPTION} Port? [y/N]" RESPONSE
  case "${RESPONSE}" in
    y|Y )
      #Enable
      sudo sed -i 's/\("${OPTION}.enabled":\).*/\1 'true',/' mymy.conf ;;
    n|N )
      sudo sed -i 's/\("${OPTION}.enabled":\).*/\1 'false',/' mymy.conf ;;
    * )     echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m " ;;
  esac;;
done

Hi,

Thanks for the solution. Well I have used following line of codes using your example but i get error: (syntax check done in https://www.shellcheck.net/ )

Code:

 for PORTOPTN in ftp http rdp smb ; do
     read -p "Do you want to enable ${PORTOPTN} port? [y/N]" responsePORTS
           case "${responsePORTS}" in
               y|Y )
                    sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'true',/' mymy.conf ;;
               n|N )
                    sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'false',/' mymy.conf ;;
                *)    echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m " ;;
            esac;;
  done

Error:

Code:

$ shellcheck myscript
 
Line 1:
 for PORTOPTN in ftp http rdp smb ; do
 ^-- SC1073: Couldn't parse this for loop.
                                    ^-- SC1061: Couldn't find 'done' for this 'do'.
 
Line 10:
                                        esac;;
                                            ^-- SC1062: Expected 'done' matching previously mentioned 'do'.
                                              ^-- SC1072: Unexpected . Fix any mentioned problems and try again.

$

Why it says "cannot find DONE for DO"?

astrogeek · 12-15-2016, 10:34 PM

Remove ;; after esac.

TashiDuks · 12-15-2016, 10:40 PM

Quote:

Originally Posted by grail

I would also force case on your test variable so you do not have to worry how the user inputs the information:

Code:

read -p "Do you want to enable ${OPTION} Port? [y/N]" RESPONSE
  case "${RESPONSE^}" in
    Y)...
    N)...

Also, TenTenths' example is fine but you will need to rework the quotes for the variables to work in the sed.

As usual, you only present a snippet of this imaginary conf file you keep using as an example, so I believe the seds can probably be made a lot simpler but would be unable to assist unless we get a better idea
of the original file.

Hi,
Thanks for the concern and I do understand what you trying to say, but I am sharing only the part of configuration file which I am working on it to make it more clear about the issue which I am facing.

Regards

TashiDuks · 12-15-2016, 10:44 PM

Quote:

Originally Posted by astrogeek

Remove ;; after esac.

Now I am getting this error:

Code:

$ shellcheck myscript
 
Line 2:
                                  read -p "Do you want to enable ${PORTOPTN} port? [y/N]" responsePORTS
                                  ^-- SC2162: read without -r will mangle backslashes.
 
Line 6:
                                                        sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'true',/' mymy.conf ;;
                                                                                                        ^-- SC2026: This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'? 
 
Line 8:
                                                        sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'false',/' mymy.conf ;;
                                                                                                        ^-- SC2026: This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'? 

$

astrogeek · 12-15-2016, 10:56 PM

Quote:

Originally Posted by TashiDuks

Now I am getting this error:

Code:

...
read -p "Do you want to enable ${PORTOPTN} port? [y/N]" responsePORTS
   ...^-- SC2162: read without -r will mangle backslashes.
sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'true',/' mymy.conf ;;
   ...^-- SC2026: This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'? 
sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'false',/' mymy.conf ;;
   ...^-- SC2026: This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'?

I am not familiar with shellcheck, but those are not actual errors, they are advisory warnings I think.

The first reminds you what read without -r will do - see man bash for that. Doesn't mean it is wrong.

The other two are telling you that true and false appear outside quotes, which may or may not be wrong. In your case I think it is wrong, based on your mymy.conf snippet format.

grail · 12-16-2016, 02:44 AM

I would also question why the true / false are not included inside the sed start and end quotes?

Code:

sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'true',/' mymy.conf ;;

sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 true,/' mymy.conf ;;

One reason you might be getting an error is due to the fact that being outside the call to sed now means the shell is handling the calls to true / false which are commands the shell will execute.

TashiDuks · 12-18-2016, 06:38 AM

Quote:

Originally Posted by astrogeek

I am not familiar with shellcheck, but those are not actual errors, they are advisory warnings I think.

The first reminds you what read without -r will do - see man bash for that. Doesn't mean it is wrong.

The other two are telling you that true and false appear outside quotes, which may or may not be wrong. In your case I think it is wrong, based on your mymy.conf snippet format.

I finally came up with following lines of code where execution is fine without any errors but it does not change any values in my config file.

Code:

#Variable
                                var1=true
                                var0=false
                                #Enable/Disable PORTS [Ports]
                                for PORTOPTN in ftp http smb mysql ssh rdp sip snmp ntp tftp telnet mssql vnc rdp;
                                  do
                                    read -p "Do you want to enable ${PORTOPTN^^} Port? [y/N]" responsePORTS
                                     case "${responsePORTS}" in
                                        y|Y )
                                             sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 "$var1",/' mymy.conf ;;
                                        n|N )
                                             sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 "$var0",/' mymy.conf ;;
                                        * )  echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m " ;;
                                     esac
                                done
                                ;;

TashiDuks · 12-18-2016, 06:40 AM

Quote:

Originally Posted by grail

I would also question why the true / false are not included inside the sed start and end quotes?

Code:

sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 'true',/' mymy.conf ;;

sudo sed -i 's/\("${PORTOPTN}.enabled":\).*/\1 true,/' mymy.conf ;;

One reason you might be getting an error is due to the fact that being outside the call to sed now means the shell is handling the calls to true / false which are commands the shell will execute.

Thanks. Is there any other option or to rephrase my line?

grail · 12-18-2016, 08:10 AM

Well I would make a search for the port option and then use s/// to change just the true or false.
Something like:

Code:

#Enable/Disable PORTS [Ports]
for PORTOPTN in ftp http smb mysql ssh rdp sip snmp ntp tftp telnet mssql vnc rdp;
do
  read -p "Do you want to enable ${PORTOPTN^^} Port? [y/N]" responsePORTS
  case "${responsePORTS^}" in
    Y ) opt='true';;
    N ) opt='false';;
    * )  echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m "
         break;;
  esac
  sudo sed -i "/$PORTOPTN/s/:.*/: $opt/" mymy.conf
done

Edit: Fixed variable as per pan64's catch

MadeInGermany · 12-18-2016, 08:49 AM

The main problem is that the shell does not substitute $var in a 'string'
Split into two strings so it becomes a concatenation of 'part1' "$var" 'part2'!
The shell then does the substution and removes all the quotes, so sed sees one string.

Code:

for PORTOPTN in ftp http rdp smb
do
    read -p "Do you want to enable ${PORTOPTN} port? [y/N]" responsePORTS
    case "$responsePORTS" in
    y|Y )
        sudo sed -i 's/^ *\('"$PORTOPTN"'\.enabled: *\)[^,]*/\1true/' mymy.conf
    ;;
    n|N )
        sudo sed -i 's/^ *\('"$PORTOPTN"'\.enabled: *\)[^,]*/\1false/' mymy.conf
    ;;
    * )
        echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m "
    ;;
    esac
done

Comment on the previous post: the break ends the loop, a continue would continue the loop.