Getting a parse error in bash script

galvantua · 02-07-2018, 07:48 AM

I am making a bash script that needs to config som files, and while testing it, I came across what shellcheck.net called a parser error in the following line:

Code:

#!/bin/bash
while true; do
read -p "Do you wish to config Open-SSH Server?: " yn 
case $yn in
[Yy]* ) echo "Starting ssh config";
open my $in,	'<', /etc/ssh/sshd_config	or die "Can't read old file: $!"; 
open my $out,	'>', /etc/ssh/sshd_config	or die "Can't write new file: $!"; 

while ( <$in> ) {
#sets functions for ssh values to reduce code(lines 12-45)
function good_value {
	if [ $valuename = PermitRootLogin ]||[ $valuename = PermitEmptyPasswords ]||[ $valuename = DebianBanner ]||[ $valuename = PasswordAuthentication ]
	then 
#...

The line in question is line 9: while ( <$in> ) {
I have a bracket at the end as well. how do i fix this parser error?

michaelk · 02-07-2018, 07:48 PM

Welcome to LinuxQuestions.

Code:

open my $in,	'<', /etc/ssh/sshd_config	or die "Can't read old file: $!"; 
open my $out,	'>', /etc/ssh/sshd_config	or die "Can't write new file: $!";

Looks like your trying to convert perl to bash. In addition, that

Code:

while ( <$in> ) 

in perl is something like

while ( my $valuename = <$in> )

However, none of the above statements will work in bash (as far as I know...) A simple loop to read a file

Code:

file="myfile"
while  read line
do
        # display $line or do somthing with $line
	echo "$line"
done <"$file"

galvantua · 02-07-2018, 08:14 PM

oh ok. i didn't realize that bash didn't get perl syntax too. does this mean i will have to change these 2 lines?

Code:

#!/bin/bash
perl -i -pe 's/PASS_MAX_DAYS	99999/PASS_MAX_DAYS	90/g' /etc/login.defs
perl -i -pe 's/PASS_MIN_DAYS	0/PASS_MAX_DAYS	10/g' /etc/login.defs

michaelk · 02-07-2018, 08:28 PM

No, they should work as is because they are both command line statements.

galvantua · 02-07-2018, 08:30 PM

oh ok. thanks for your help, it is most appreciated!