C program that displays shapes. Keep getting errors.

boilers969 · 10-10-2010, 07:18 PM

Well for me it doesn't. I'm just asking for help.

Sergei Steshenko · 10-10-2010, 07:21 PM

Quote:

Originally Posted by boilers969

Well for me it doesn't. I'm just asking for help.

First read the C99 standard, then we'll deal with the copy->paste->indent problem.

boilers969 · 10-10-2010, 07:21 PM

Well for some reason it doesn't work for me. I'm just asking for help.

boilers969 · 10-10-2010, 07:22 PM

I'm not worried about that. I just want my program to compile.

Sergei Steshenko · 10-10-2010, 07:22 PM

Quote:

Originally Posted by boilers969

Well for some reason it doesn't work for me. I'm just asking for help.

Read the C99 standard first.

boilers969 · 10-10-2010, 07:24 PM

I did. When you first posted it.

sag47 · 10-10-2010, 07:27 PM

Quote:

Originally Posted by boilers969

So i attempted it with 3 separate switch statements.

Code:

#include<stdio.h>

int main()
{
while(1){
char shape;
char s,h,f;
int row;
printf("Enter shape type (s/h/f):");
scanf("%c",&shape);
printf("Enter shape length: ");
scanf("%d",&row);
if(row<=0)
printf("Shape length cannot be negative. Try again\n");
}
for(int s=1){
switch(s)
{
case 1:
{int i,row;
for(i=row;i>=1;i--)
printf("*\n");
break;}}}
for(int h=2){
switch(h)
{
case 2:
{int i,j,k,row,m;
m=row;
for(i=1 ; i<=m; i++)
{
for (j=1 ; j>=row; j--)
printf(" ");
{for(k=1; k<=i; k=k+1)
printf("*");
printf("\n");}}
break;}}}
for(int f=3)
switch(f)
{
case 3:
{int i,j,k,row,m;
m=row;
for(i=0;i<m;i++)
{
printf("\n");
for(k=0;k<row;k++)
printf(" ");
for(j=0;j<=i;j++)
printf(" *");
row--;
}}}
printf("\n");
break;}
}}
return 0;
}

You're attacking this all wrong. First you need to indent like Nylex said.

Quote:

Originally Posted by Nylex

Again, it would help if you put indentation in.

Another issue that I have with you doing is your fancy for loops not using curly brackets {}. Although it is not programmatically incorrect it is a bad habit just like not indenting. The reason is you end up with code like this (directly pulled from your code):

Code:

for (j=1 ; j>=row; j--)
    printf(" ");
{
    for(k=1; k<=i; k=k+1)
        printf("*");
    printf("\n");
}

So in the future you should write your for loops like so which will make your code more accurate and easier to read if you're on a project with more than one person programming:

Code:

for(k=1; k<=i; k=k+1)
{
    printf("*");
}

That problem occurs at line 41 of your code which I will give you back fully indented. Make indenting a habit and your troubleshooting will get dramatically easier and you'll find that you can easily write accurate code the first time.

Code:

#include<stdio.h>

int main()
{
    while(1)
    {
        char shape;
        char s,h,f;
        int row;
        printf("Enter shape type (s/h/f):");
        scanf("%c",&shape);
        printf("Enter shape length: ");
        scanf("%d",&row);
        if(row<=0)
        printf("Shape length cannot be negative. Try again\n");
    }
    for(int s=1)
    {
        switch(s)
        {
            case 1:
            {
                int i,row;
                for(i=row;i>=1;i--)
                    printf("*\n");
                break;
            }
        }
    }
    for(int h=2)
    {
        switch(h)
        {
            case 2:
            {
                int i,j,k,row,m;
                m=row;
                for(i=1 ; i<=m; i++)
                {
                    for (j=1 ; j>=row; j--)
                        printf(" ");
                    {
                        for(k=1; k<=i; k=k+1)
                            printf("*");
                        printf("\n");
                    }
                }
                break;
            }
        }
    }
    for(int f=3)
        switch(f)
        {
            case 3:
            {
                int i,j,k,row,m;
                m=row;
                for(i=0;i<m;i++)
                {
                    printf("\n");
                    for(k=0;k<row;k++)
                        printf(" ");
                    for(j=0;j<=i;j++)
                        printf(" *");
                    row--;
                }
            }
        }
    printf("\n");
    break;
}




}}
return 0;
}

Notice at the end:

Code:

}}
return 0;
}

That is not inside of your main function at all... indenting would have avoided that.

As for the rest of your code I think another member would better be able to help you using the indented version. I don't know how to program C. At least not outside your basic hello world or embedded circuits.

Sergei Steshenko · 10-10-2010, 07:30 PM

Quote:

Originally Posted by boilers969

I did. When you first posted it.

If so, justify according to the standard the following pieces of your code:

Code:

shape='s';
shape='h';
shape='f';

,

Code:

for(int s=1,int h=2,int f=3)

,

Code:

switch(s,h,f)

,

Code:

{int i,row;
for(i=row;i>=1;i--)

.

boilers969 · 10-10-2010, 07:30 PM

Thanks sag47. Now if only I could figure out what's wrong.

Sergei Steshenko · 10-10-2010, 07:32 PM

Quote:

Originally Posted by boilers969

Thanks sag47. Now if only I could figure out what's wrong.

Justify every line of your code by paragraphs of C99 standard. Start from the ones mentioned in http://www.linuxquestions.org/questi...ml#post4123274 .

boilers969 · 10-10-2010, 07:35 PM

Haha that's obviously why I'm on here. And your c99 standard isn't helping me.

sag47 · 10-10-2010, 07:38 PM

Since you're on Windows hopefully you're not using Notepad. Better to use something like Notepad++ which is what I formatted your code in around 15 seconds.

Sergei Steshenko · 10-10-2010, 07:48 PM

Quote:

Originally Posted by boilers969

... your c99 standard isn't helping me.

Then programming is a wrong thing for you to do. Your code shows that you either never read the standard or didn't bother to understand.

boilers969 · 10-10-2010, 07:55 PM

I'm on windows but I'm using Putty.
Sergei, i was hoping for help directly, not getting refered to a book.

Sergei Steshenko · 10-10-2010, 08:01 PM

Quote:

Originally Posted by boilers969

...
Sergei, i was hoping for help directly, not getting refered to a book.

And that's the problem. Various posters including myself pointed you to the exact places in your code which are hopelessly wrong. And you were given sources of info to get knowledge from.

Instead of reading and then asking you insist on being lazy and exploiting others. I.e. you are fiercely resiting reading and comprehending. In real life standards are sometimes 700 pages long and maybe longer. Nobody will hold your hand begging you to read.