Bash

The_JinJ · 02-13-2005, 12:20 PM

I am writing a wee script to get an ip and compare to an existing file - the results of the 2 cat commands are identical but no matter what the files contain it will always treat this as false....If both files have exactly the same it will never print Hello, same if both are different.....heellpp!!

#!/bin/sh
#
# Get external IP address #
/usr/bin/wget http://www.xxxx/ip.php

result1=$(cat ip.php)
result2=$(cat ip.old)

echo $result1
echo $result2

if [ '$result1' = '$result2' ]; then
echo "hello"
fi

mv ip.php ip.old

DoubleOTeC · 02-13-2005, 01:45 PM

I think you're using the wrong comparison operator.

i think it should be if [ "result1" == "result2" ];

lemme know...

crabboy · 02-13-2005, 01:56 PM

The single equal operator is correct.

Use double quotes around your variables in the if condition.

Code:

#!/bin/sh

result1=`cat ip.php`
result2=`cat ip.old`

echo "Result1 is [$result1]"
echo "Result2 is [$result2]"

if [ "$result1" = "$result2" ]; then
  echo "Results are equal"
fi

Code:

$ ./testeq.sh
Result1 is [192.168.10.130]
Result2 is [192.168.10.130]
Results are equal

The_JinJ · 02-13-2005, 02:11 PM

Quote:

Originally posted by crabboy
The single equal operator is correct.

Use double quotes around your variables in the if condition.

Code:

#!/bin/sh result1=`cat ip.php` result2=`cat ip.old` echo "Result1 is [$result1]" echo "Result2 is [$result2]" if [ "$result1" = "$result2" ]; then echo "Results are equal" fi

Code:

$ ./testeq.sh Result1 is [192.168.10.130] Result2 is [192.168.10.130] Results are equal

Double quotes worked!! I swear it was giving an error earlier

Thanks for the assistance