BASH : syntax error

semaja2 · 01-25-2006, 11:39 PM

Hey guys i make alot of bash scripts on windows in notepad2 but when i upload them to my suse 10 box they all end up with this error

./newconfig: line 71: syntax error near unexpected token `done'
./newconfig: line 71: `done'

I have checked the scripts with vim and removed extra formatting but the scripts still fail, even if i copy and paste into vim

Code:

#!/bin/bash

function menuinfo {
echo Welcome to the Kings LAN gamer server config edit script
echo
echo "This script was built by Andrew James (semaja2)"
echo
echo This script will allow you to edit the configs for $1
echo with ease.
echo
echo This script is licensed under the GPL, and is only to be used for no profit
echo
echo
echo Select the menu number for the config you want to edit
}



clear
menuinfo

EDIT="plugins.ini server.cfg users.ini"
select edt in $EDIT; do


	if [ "$edt" = "plugins.ini" ]; then
	
	echo Editing plugins.ini for $1
	
	vi /home/gserver/games/$1/addons/amxmodx/configs/plugins.ini
	
	clear
	
	menuinfo
	
	if [ "$edt" = "server.cfg" ]; then
	
	echo Editing plugins.ini for $1
	
	vi /home/gserver/games/$1/server.cfg
	
	clear
	
	menuinfo
	
	if [ "$edt" = "users.ini" ]; then
	
	echo Editing plugins.ini for $1
	
	vi /home/gserver/games/$1/addons/amxmodx/configs/users.ini
	
	clear
	
	menuinfo
	
	else
	
	clear
	menuinfo
	echo
	echo
	echo ERROR : BAD SELECTION, TRY AGAIN
	fi
done

bobbelfield · 01-25-2006, 11:52 PM

Put a new line under done and try it again
Keep a new line under all scripts

semaja2 · 01-25-2006, 11:57 PM

Quote:

Originally Posted by bobbelfield

Put a new line under done and try it again
Keep a new line under all scripts

nope that didnt fix it

xhi · 01-26-2006, 12:22 AM

replace the middle two ifs with elif..

Code:

if [ "$edt" = "plugins.ini" ]; then
    echo Editing plugins.ini for $1
    vi /home/gserver/games/$1/addons/amxmodx/configs/plugins.ini
    clear
    menuinfo


    elif [ "$edt" = "server.cfg" ]; then
    echo "Editing plugins.ini for $1"
    vi /home/gserver/games/$1/server.cfg
    clear
    menuinfo


    elif [ "$edt" = "users.ini" ]; then
    echo Editing plugins.ini for $1
    vi /home/gserver/games/$1/addons/amxmodx/configs/users.ini
    clear
    menuinfo

    else
    clear
    menuinfo
    echo
    echo
    echo ERROR : BAD SELECTION, TRY AGAIN
    fi

rylan76 · 01-26-2006, 12:28 AM

I experienced something similar once with bash scripts originating in Windows for MingW. I think I did

dos2unix

on the .sh files before executing them in Linux. Have you tried this?

I think it is the DOS / Windows format of line end indications that are giving you the problem (CR/LF's instead of just CR's? Or is it LF's? Unsure).

Anyway, dos2unix converts textfiles, maybe it will help.

bobbelfield · 01-26-2006, 12:30 AM

Sorry im not too good on scripts yet but I notice there are 3 if statements and only one fi . Would that work? Have to leave it to someone else .

Edit Piped at the post ..good stuff

semaja2 · 01-26-2006, 12:33 AM

ahh your right thanks so much, i clearly over looked the if statments which were ment to be elif, thanks again

ill also look at that dos2unix converter becuase i really like notepad2 since it colours parts of code to make it easier to edit