User input keeps kicking error: Yes command not found

acidblue · 04-06-2009, 05:19 PM

I'm trying to compare two strings in an If..then statement and am having an awful time trying to get to work.
The user has to enter either yes or no to a question, but i keep getting "yes: command not found"
here is a sample:

echo 'Is this for GH 3 part? yes/no'
read GH_answer
echo $GH_answer

if ["$GH_answer" = "yes"];then
GH_result = $(($target_ppm - $current_ppm / $target_ppm) * 8 * $res_gallons)
Micro = $GH_result * 2
echo 'GH Bloom is $GH_result'
echo 'Micro is $Micro'
else

echo 'Is this for Flora Nova 2 part? yes/no'
read FN_answer
if ["$FN_answer" = "yes"];then
FN_result=$(($target_ppm - $current_ppm) / $target_ppm * 8 * $res_gallons)
echo "Then add $FN_result ml of Flora Nova Bloom"
else
echo 'Please restart, it must be one or the other.'

fi
fi

I've tried this several different ways and keep getting the same error, when ever the user inputs yes or no.
I'm a bit new to bash scripting, so any help would be greatly appreciated.

anomie · 04-06-2009, 05:26 PM

I ran your script in with a trace on to reproduce the problem. Here's what I saw:

Code:

$ sh -x hmm.sh 
+ echo 'Is this for GH 3 part? yes/no'
Is this for GH 3 part? yes/no
+ read GH_answer
yes
+ echo yes
yes
+ '[yes' = 'yes]'
hmm.sh: line 7: [yes: command not found

Line 7 (after I added a sh-bang line) is:

Code:

if ["$GH_answer" = "yes"] ; then

I correct that by using white space, like so:

Code:

if [ "$GH_answer" == "yes" ] ; then

You'll need to do the same in a couple other places in your script as well.

acidblue · 04-06-2009, 05:54 PM

Oh yes the double ==. and white space i never would of thought of that, thanks.
Now i'm getting an error on my math: syntax error near unexpected token '/'.
'/' is for division?

ArfaSmif · 04-06-2009, 08:56 PM

Quote:

Originally Posted by acidblue

Oh yes the double ==. and white space i never would of thought of that, thanks.
Now i'm getting an error on my math: syntax error near unexpected token '/'.
'/' is for division?

You can use the function "expr" to evaluate expressions in your script. The forward slash does not imply division in a script unless you use it it in something like expr ARG1 / ARG2