[SOLVED] Trying to tar from files listed in .txt file

Batistuta_g_2000 · 03-11-2013, 10:08 AM

Quote:

Originally Posted by shivaa

Files and their permissions seem ok. But I don't know from where these command not found errors are coming.

I feel, it would be better if you can post whole script once (if something is confidential, then you can hide that and use dummy entry at that place).

I have set up 10 files in important_files directory and populated with jargon.
I have set up a config script with variables the user should be able to change.
I have a script which checks these variables to see if are present and correct (exist).
The script then should awk the lines from the confile.cfg and populate a backuplist.txt.
From this backup list the script should tar files into tarball and write to errorlog:
tar -czvf $BACKUP_FILE -T "$BACKUP_TARGETS" > "$LOGOUT" 2> "$LOGERR"

For some reason the script is reading the confile.cfg and trying to run each line as a command? - Is this normal, can I subdue this output or redirect it? and How would I do it?

Here seems to be the offending part:

. $CONFILE
+ . /home/ubuntu/confile.cfg
###############################################################
###############################################################
# CONFIGURATION FILE ASSIGNMENT 1 #
# Student: XXXXXXXXXXXXXXX #
###############################################################

# Please enter FULL directory of the files you need backed up after "=" below:
IMPORTANT_FILES_DIRECTORY=$HOME/assignment1/important_files
++ IMPORTANT_FILES_DIRECTORY=/root/assignment1/important_files

# Please enter FULL directory where you want the files be backed up to after "=" below:
BACKUP_FILES_DIRECTORY=$HOME/assignment1/backups
++ BACKUP_FILES_DIRECTORY=/root/assignment1/backups

# Please enter FULL directory where you want the backups to be restored to after "=" below:
RESTORE_FILES_DIRECTORY=$HOME/assignment1/restores
++ RESTORE_FILES_DIRECTORY=/root/assignment1/restores

# Please enter the Project Name to be assigned to the new backup file after "=" below:
PROJECT_NAME=ASSIGNMENT1
++ PROJECT_NAME=ASSIGNMENT1

# Please list the files or directories to be backed up on the next line, hit enter after each line:
/home/ubuntu/assignment1/important_files/file1
++ /home/ubuntu/assignment1/important_files/file1
/home/ubuntu/assignment1/important_files/file1: line 1: kjsdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 2: asdfj: command not found
/home/ubuntu/assignment1/important_files/file1: line 3: asdfjasdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 4: asdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 5: asdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 6: asdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 7: bdrtwertewgrt: command not found
/home/ubuntu/assignment1/important_files/file1: line 8: gsbvwgtr: command not found
/home/ubuntu/assignment1/important_files/file1: line 9: bwetbtrw: command not found
/home/ubuntu/assignment1/important_files/file1: line 10: bwdfre: command not found
/home/ubuntu/assignment1/important_files/file2
++ /home/ubuntu/assignment1/important_files/file2
/home/ubuntu/assignment1/important_files/file2: line 1: rrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr: command not found......................AND SO ON....

shivaa · 03-11-2013, 10:26 AM

I am sorry, but here we should not share anything privately. In the meantime, you can exclude the reading of this config file, as:

Code:

awk 'NR==20,NR==EOF' "$CONFILE" | grep -v confile.cfg > $TMP/backuplist.txt

Batistuta_g_2000 · 03-11-2013, 12:19 PM

Quote:

Originally Posted by shivaa

I am sorry, but here we should not share anything privately. In the meantime, you can exclude the reading of this config file, as:

Code:

awk 'NR==20,NR==EOF' "$CONFILE" | grep -v confile.cfg > $TMP/backuplist.txt

Thanks for that. Do you have any idea why the config file at the start of my script is trying to run each file listed from NR==20 to EOF? - is . $CONFILE correct?

So in the top of my script :

Code:

#!/bin/bash
BASEDIR=$(cd `dirname $0` && pwd)
CONFILE=$BASEDIR/confile.cfg
. $CONFILE

root@ubuntu:~# ./assignment1.sh
/home/ubuntu/assignment1/important_files/file1: line 1: kjsdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 2: asdfj: command not found
/home/ubuntu/assignment1/important_files/file1: line 3: asdfjasdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 4: asdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 5: asdf: command not found
/home/ubuntu/assignment1/important_files/file1: line 6: asdf: command not found

shivaa · 03-11-2013, 12:32 PM

Code:

. $CONFILE

Is the problem. A "." means you're sourcing the $CONFILE i.e. reading this file line by line and trying to set everything mentioned in the file.

Simply comment it out. It's not necessory in script.

Code:

#!/bin/bash
BASEDIR=$(cd `dirname $0` && pwd)
CONFILE=$BASEDIR/confile.cfg
#. $CONFILE          # Comment out this line

Batistuta_g_2000 · 03-11-2013, 12:51 PM

Quote:

Originally Posted by shivaa

Code:

. $CONFILE

Is the problem. A "." means you're sourcing the $CONFILE i.e. reading this file line by line and trying to set everything mentioned in the file.

Simply comment it out. It's not necessory in script.

Code:

#!/bin/bash
BASEDIR=$(cd `dirname $0` && pwd)
CONFILE=$BASEDIR/confile.cfg
#. $CONFILE          # Comment out this line

Ok sorry, a bit of background:
The script has variables set in the confile.cfg which it needs to use.
The confile.cfg must be in the base directory (same location as he script), so is set up as above.
I need to source the confile.cfg in the script so it can be read - is there a better way than. confile.cfg which will not cause the lines to be read from each referenced file?

Thanks

shivaa · 03-11-2013, 01:04 PM

Better to define those variables in script itself. Else remove those commands from $CONFILE file.

Batistuta_g_2000 · 03-12-2013, 08:16 AM

Quote:

Originally Posted by shivaa

Better to define those variables in script itself. Else remove those commands from $CONFILE file.

Ok got it sorted:
set my confile to
Enter file names you want to back up after the # below
#file1
#file2....etc

Then in script - awk'd lines to tempfile and sed'd out "#" to tempfile2 and copied to "important_files" directory - Then I ran the script to tar -T from "tempfile2" list within the "important_files" directory" so just got the actual files not full path. BINGO... thanks for the help.