LinuxQuestions.org - That which could be fixed in SBo thread.

- Slackware (https://www.linuxquestions.org/questions/slackware-14/)

- - That which could be fixed in SBo thread. (https://www.linuxquestions.org/questions/slackware-14/that-which-could-be-fixed-in-sbo-thread-4175532869/)

That which could be fixed in SBo thread.

This is a thread aimed at fixing SlackBuilds in SBO that are currently having any build issues and need repairs, fixes, patches, etc. Try to stick to the current format.

This post is only to fix and repair existing SlackBuild script, not get newer versions of packages.

THIS THREAD IS AIMED AT -CURRENT USAGE with resyncs from the SBo master repo via git/svn. Stable releases should be okay, unless otherwise noted.

---------------------
TiMidity++.SlackBuild
---------------------
line 96
autoreconf > ./autogen.sh

Original command returns an error when ran.

--------------------------
gst-plugins-bad.SlackBuild
--------------------------
line 87(+88)
make install DESTDIR=$PKG
> cp -v $PKG/usr/include/libmodplug/stdafx.h $PKG/usr/include/stdafx.h

when building gst-plugins-bad against libmodplug, compiler generates stop error stating stdafx.h was not found.

Quote:

Originally Posted by ReaperX7 (Post 5310925)

TiMidity++.SlackBuild
---------------------
line 96
autoreconf > ./autogen.sh

Original command returns an error when ran.

Are you running this package in -current or in -stable?
I just tested this on slackware64-14.1 VM and it's working fine

-Current at the moment. New versions of tool sets may be producing problems that may need to start getting tracked. Plus I'm using sbotools to manage the SBo packages which stays in sync with the git/svn SBO repo.

Yes, we are aware of new toolchain that might break some scripts in SBo, but since -current is not officially supported, it will be fixed during the time when next Slackware is about to be released

Ponce (one of the SBo admins) is already maintaining a git branch which targets slackware-current: https://github.com/Ponce/slackbuilds

Your fixes/patches/whatever should be based on that, not on the Slackware 14.1 repository of slackbuilds.org.

Thanks Eric for pointing Reaper at my (personal) repo (not affiliated with SBo): in fact I already fixed TiMidity++ for building on -current there. :)

ReaperX7: I think the problem you attribute to gst-plugins-bad is instead of libmodplug that seems to have a wrong path for its own includes in its pkgconfig file: this patch for the SlackBuild fixes it.
I'll send it to Larry, the libmodplug maintainer too, as it applies to stable too: if it's ok for him I'll send the fix also upstream.
BTW, thanks for reporting the issue!

Code:

From 6fc93b2a34d46ada1faa10cb86cef496e2e1fb61 Mon Sep 17 00:00:00 2001

From: Matteo Bernardini <ponce@slackbuilds.org>

Date: Tue, 3 Feb 2015 16:27:32 +0100

Subject: [PATCH] libraries/libmodplug: Fix includes location in the pkgconfig

 file.



Signed-off-by: Matteo Bernardini <ponce@slackbuilds.org>

---

 libraries/libmodplug/libmodplug.SlackBuild | 5 ++++-

 1 file changed, 4 insertions(+), 1 deletion(-)



diff --git a/libraries/libmodplug/libmodplug.SlackBuild b/libraries/libmodplug/libmodplug.SlackBuild

index 9570bb4..df39b69 100644

--- a/libraries/libmodplug/libmodplug.SlackBuild

+++ b/libraries/libmodplug/libmodplug.SlackBuild

@@ -24,7 +24,7 @@

 

 PRGNAM=libmodplug

 VERSION=${VERSION:-0.8.8.5}

-BUILD=${BUILD:-1}

+BUILD=${BUILD:-2}

 TAG=${TAG:-_SBo}

 

 if [ -z "$ARCH" ]; then

@@ -71,6 +71,9 @@ find -L . \

 

 patch -p1 < $CWD/libmodplug-0.8.4-timiditypaths.patch

 

+# Fix the location of the includes in the pkgconfig file

+sed -i "s|includedir}$|includedir}/libmodplug|" libmodplug.pc.in

+

 CFLAGS="$SLKCFLAGS" \

 CXXFLAGS="$SLKCFLAGS" \

 ./configure \

-- 

2.2.2

You're welcome ponce.

If I find more problems, and honestly if anyone finds any problems, this topic could be used as a good starting point to finding the real issues at hand, or just rework things as needed to work better.

Because SBO is community, and most of you guys post here that contribute to SBO, maybe this can be a little bit of help.

The faster things can be found, the faster things can be fixed, patched, etc. upstream.

Quote:

Originally Posted by ReaperX7 (Post 5310925)

---------------------
TiMidity++.SlackBuild
---------------------
line 96
autoreconf > ./autogen.sh

Original command returns an error when ran.

I pushed this a few days ago, please test it out.

Quote:

Originally Posted by elyk (Post 5311625)

I pushed this a few days ago, please test it out.

I'll resync my sbo pool tomorrow and give it a tryout. Thanks.

The slackbuild for lua52 has problems when run using fakeroot. I reported the problem to ponce by email some time ago, but I never received a reply. I think it would be interesting to fix it.

but at SBo we don't support fakeroot for building so, IMHO, there's nothing to be fixed.

I'll paste here the diff you sent me, if it can be useful to other people like you using fakeroot

Code:

diff -urN a/lua52.SlackBuild b/lua52.SlackBuild

--- a/lua52.SlackBuild        2014-08-22 17:15:51.000000000 +0200

+++ b/lua52.SlackBuild        2014-12-03 20:38:40.197665369 +0100

@@ -60,15 +60,18 @@

  MYLIBS="-lncurses" \

  CFLAGS="$SLKCFLAGS \$(MYCFLAGS) -DLUA_COMPAT_ALL -DLUA_USE_LINUX" \

  INSTALL_TOP=/usr \

-  INSTALL_LIB=/usr/lib${LIBDIRSUFFIX} \

-  INSTALL_CMOD=/usr/lib${LIBDIRSUFFIX}/lua/5.2

+  INSTALL_LIB=/usr/lib${LIBDIRSUFFIX}

 

-make linux install \

+make linux local \

  MYLIBS="-lncurses" \

  CFLAGS="$SLKCFLAGS \$(MYCFLAGS) -DLUA_COMPAT_ALL -DLUA_USE_LINUX" \

  INSTALL_TOP=$PKG/usr \

-  INSTALL_LIB=$PKG/usr/lib${LIBDIRSUFFIX} \

-  INSTALL_CMOD=/usr/lib${LIBDIRSUFFIX}/lua/5.2

+  INSTALL_LIB=$PKG/usr/lib${LIBDIRSUFFIX}

+

+mkdir -p $PKG/usr

+cd install

+find . -type f -print0 | cpio -p -0 --make-directories $PKG/usr

+cd ..

 

 # Now let's build the shared library

 mkdir -p shared

Oh, OK. I didn't know fakeroot was not supported, thanks.

re-reading my answer I think that, aided by my bad english, I may have sounded rude: it wasn't my intention at all, I hope you understand :)

consider that I'm still thinking, when I'll find enough spare time to test stuff depending on it too, of reworking lua build scripts for trying to have multiple lua version installed together: it could be that the new ones will accidentally work also with fakeroot, who knows! ;)

Is there a build flag for lua52 like --disable-fakeroot?

Quote:

Originally Posted by ponce (Post 5311278)

ReaperX7: I think the problem you attribute to gst-plugins-bad is instead of libmodplug that seems to have a wrong path for its own includes in its pkgconfig file: this patch for the SlackBuild fixes it.
I'll send it to Larry, the libmodplug maintainer too, as it applies to stable too: if it's ok for him I'll send the fix also upstream.
BTW, thanks for reporting the issue!

Code:

From 6fc93b2a34d46ada1faa10cb86cef496e2e1fb61 Mon Sep 17 00:00:00 2001

From: Matteo Bernardini <ponce@slackbuilds.org>

Date: Tue, 3 Feb 2015 16:27:32 +0100

Subject: [PATCH] libraries/libmodplug: Fix includes location in the pkgconfig

 file.



Signed-off-by: Matteo Bernardini <ponce@slackbuilds.org>

---

 libraries/libmodplug/libmodplug.SlackBuild | 5 ++++-

 1 file changed, 4 insertions(+), 1 deletion(-)



diff --git a/libraries/libmodplug/libmodplug.SlackBuild b/libraries/libmodplug/libmodplug.SlackBuild

index 9570bb4..df39b69 100644

--- a/libraries/libmodplug/libmodplug.SlackBuild

+++ b/libraries/libmodplug/libmodplug.SlackBuild

@@ -24,7 +24,7 @@

 

 PRGNAM=libmodplug

 VERSION=${VERSION:-0.8.8.5}

-BUILD=${BUILD:-1}

+BUILD=${BUILD:-2}

 TAG=${TAG:-_SBo}

 

 if [ -z "$ARCH" ]; then

@@ -71,6 +71,9 @@ find -L . \

 

 patch -p1 < $CWD/libmodplug-0.8.4-timiditypaths.patch

 

+# Fix the location of the includes in the pkgconfig file

+sed -i "s|includedir}$|includedir}/libmodplug|" libmodplug.pc.in

+

 CFLAGS="$SLKCFLAGS" \

 CXXFLAGS="$SLKCFLAGS" \

 ./configure \

-- 

2.2.2

I've talked to ponce in a separate email about gst-plugins-bad. The issue is that the version of gst-plugins-bad on SBo doesn't use include statements correctly like the gst-plugins-bad 1.x version does. I sent ponce a patch so that gst-plugins-bad can compile with libmodplug.

Code:

# cat libmodplug-include.patch

diff -Naur gst-plugins-bad-0.10.23.orig/ext/modplug/gstmodplug.cc gst-plugins-bad-0.10.23/ext/modplug/gstmodplug.cc

--- gst-plugins-bad-0.10.23.orig/ext/modplug/gstmodplug.cc        2012-01-18 12:32:55.000000000 +0000

+++ gst-plugins-bad-0.10.23/ext/modplug/gstmodplug.cc        2015-02-03 16:31:44.428094306 +0000

@@ -50,7 +50,7 @@

 #define WORDS_BIGENDIAN 0

 #endif

 

-#include <stdafx.h>

+#include <libmodplug/stdafx.h>

 #include <libmodplug/sndfile.h>

 

 #include "gstmodplug.h"

Code:

# cat gst-plugins-bad.SlackBuild.patch

--- gst-plugins-bad.SlackBuild.orig        2015-02-03 16:38:28.199078554 +0000

+++ gst-plugins-bad.SlackBuild        2015-02-03 16:39:00.238077304 +0000

@@ -71,6 +71,9 @@

  \( -perm 666 -o -perm 664 -o -perm 600 -o -perm 444 -o -perm 440 -o -perm 400 \) \

    -exec chmod 644 {} \;

 

+# Fix libmodplug include directory.

+patch -p1 < $CWD/libmodplug-include.patch

+

 CFLAGS="$SLKCFLAGS" \

 CXXFLAGS="$SLKCFLAGS" \

 ./configure \